1583325 - [Protections Panel] Change opacity of stripes

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P3)

Description

[Eric Pang [:epang] UX]

Attachment: TP-Off Stripes.png

The current opacity of the stripes when Tracking Protection is off is set at 35% and is a little dark. Can we update to 20% opacity? Thanks

Comment 1

[Tim Huang[:timhuang]]

Hi Eric,

Do you think we need to change the color in dark mode as well? Right now we are using a general CSS variable '--arrowpanel-dimmed' for the color of stripes. However, there is no general CSS color variable for more lighter color here. So we need to use our own color. The '--arrowpanel-dimmed' defines differently in dark mode, so we need a stripe color for the dark mode as well. we can either still use it in dark mode or you can specify a different color here.

What do you think?

Comment 2

[Eric Pang [:epang] UX]

Let's keep the current colour but reduce the opacity to 5% for dark mode, thanks Tim!

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Talked to Tim - he won't have time to work on this bug this week. Taking over.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1583325 - Lighten the stripes in the TP switch section background when OFF. r=johannh,timhuang

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: With the patch

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: With the patch - dark mode

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f53153babb6f
Lighten the stripes in the TP switch section background when OFF. r=timhuang

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/f53153babb6f

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9097589 [details]
Bug 1583325 - Lighten the stripes in the TP switch section background when OFF. r=johannh,timhuang

Beta/Release Uplift Approval Request

• User impact if declined: Striking/contrasty visuals in a place where we want subtlety.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Visual polish. Colors updated, dogfooded in Nightly for a few days.
• String changes made/needed:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9097589 [details]
Bug 1583325 - Lighten the stripes in the TP switch section background when OFF. r=johannh,timhuang

Non crucial but also not complicated twiddling of stripes.
OK for beta 14. (But no more polish uplifts past that, please)

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/546ee49d66a1

Comment 12

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue using an affected Nightly build from 2019-09-23.

This is verified fixed on latest Nightly 71.0a1, Beta 70.0b14 under macOS 10.14, Windows 10 x64 and Ubuntu 18.04 x64.