Closed Bug 1583325 Opened 3 months ago Closed 2 months ago

[Protections Panel] Change opacity of stripes

Categories

(Firefox :: Site Identity, task, P3)

task

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: epang, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel][skyline])

Attachments

(4 files)

Attached image TP-Off Stripes.png

The current opacity of the stripes when Tracking Protection is off is set at 35% and is a little dark. Can we update to 20% opacity? Thanks

Assignee: nobody → tihuang
Status: NEW → ASSIGNED

Hi Eric,

Do you think we need to change the color in dark mode as well? Right now we are using a general CSS variable '--arrowpanel-dimmed' for the color of stripes. However, there is no general CSS color variable for more lighter color here. So we need to use our own color. The '--arrowpanel-dimmed' defines differently in dark mode, so we need a stripe color for the dark mode as well. we can either still use it in dark mode or you can specify a different color here.

What do you think?

Flags: needinfo?(epang)

Let's keep the current colour but reduce the opacity to 5% for dark mode, thanks Tim!

Flags: needinfo?(epang)
Priority: -- → P3
Whiteboard: [privacy-panel][triage][skyline] → [privacy-panel][skyline]

Talked to Tim - he won't have time to work on this bug this week. Taking over.

Assignee: tihuang → nhnt11
Attached image With the patch
Attachment #9097590 - Attachment mime type: text/plain → image/png
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f53153babb6f
Lighten the stripes in the TP switch section background when OFF. r=timhuang
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9097589 [details]
Bug 1583325 - Lighten the stripes in the TP switch section background when OFF. r=johannh,timhuang

Beta/Release Uplift Approval Request

  • User impact if declined: Striking/contrasty visuals in a place where we want subtlety.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Visual polish. Colors updated, dogfooded in Nightly for a few days.
  • String changes made/needed:
Attachment #9097589 - Flags: approval-mozilla-beta?

Comment on attachment 9097589 [details]
Bug 1583325 - Lighten the stripes in the TP switch section background when OFF. r=johannh,timhuang

Non crucial but also not complicated twiddling of stripes.
OK for beta 14. (But no more polish uplifts past that, please)

Attachment #9097589 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I have reproduced this issue using an affected Nightly build from 2019-09-23.

This is verified fixed on latest Nightly 71.0a1, Beta 70.0b14 under macOS 10.14, Windows 10 x64 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.