1583330 - Can not modify immutable data container'Can not modify immutable data container' when calling method: [calIRecurrenceInfo::appendRecurrenceItem]

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Related to or even caused by bug 1581909?

Getting a ton of these in the console

console.warn: Lightning: Message: [Exception... "Can not modify immutable data container'Can not modify immutable data container' when calling method: [calIRecurrenceInfo::appendRecurrenceItem]" nsresult: "0x80460002 (NS_ERROR_OBJECT_IS_IMMUTABLE)" location: "JS frame :: file:///home/magnus/Code/tb/mozilla/obj-x86_64-pc-linux-gnu/dist/bin/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calStorageCalendar.js :: _assureRecurringItemCaches/< :: line 1749" data: no]

https://searchfox.org/comm-central/rev/30f32c40a88dc34746d22697dad8fe99c7922054/calendar/providers/storage/calStorageCalendar.js#1749

Comment 1

[Magnus Melin [:mkmelin]]

STR: subscribe to https://www.thunderbird.net/media/caldata/FinlandHolidaysSwedish.ics

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1583330-cached-item-delete-1.diff

Turns out this is caused by an idiot (me) doing things in the wrong order. Bug 1581909 didn't fix it at all.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9097527 [details] [diff] [review]
1583330-cached-item-delete-1.diff

Review of attachment 9097527 [details] [diff] [review]:
-----------------------------------------------------------------

r+ With this patch I no longer get those errors in the console, and the changes seem fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1aad624d21ac
Delete calendar item from cache before checking it's not in the cache. r=pmorris

Comment 5

[Jorg K (CEST = GMT+2)]

Great selection of spelling errors in this code :-( - Since when it "can not" correct in English?

Comment 6

[Jorg K (CEST = GMT+2)]

Sigh, that broke comm/calendar/test/unit/test_providers.js. I'll let you deal with the bustage.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b026e14ea5d
follow-up - Stop checking item creation date is null after creating the item; rs=bustage-fix