Closed Bug 1583398 Opened 5 years ago Closed 5 years ago

Imported logins do not display breach indicators without refresh

Categories

(Firefox :: about:logins, defect, P1)

Product:
Firefox
Component:
about:logins
Version:
70 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ssage, Assigned: jaws)

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(3 files)

Bug 1583398 - Newly added logins should show breach notifications if they apply. r?MattN
47 bytes, text/x-phabricator-request
Details | Review
Bug 1583398 - Move error rendering to the render function so calling render is idempotent. r?MattN
47 bytes, text/x-phabricator-request
Details | Review
Bug 1583398 - Store breaches in the remote store for tests when expected, and otherwise prevent all of the fxmonitor logspam when running aboutlogins mochitest-browser tests. r?MattN
47 bytes, text/x-phabricator-request
Details | Review

When I imported my credentials from Chrome, I did not see any breached results (no indicators, no dropdown option to find them). Upon refreshing the about:logins view, I found 2 breached accounts, displaying as expected.

Priority: -- → P1

I believe this is because we don't compute the breached logins upon storage changes like addLogin, only when we're sending all logins. This problem would also happen if about:logins is open while sync downloads new logins from another client.

status-firefox69: --- → disabled
status-firefox70: --- → fix-optional
status-firefox71: --- → affected
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Summary: Imported logins from Chrome did not display breached results without refresh → Imported logins do not display breach indicators without refresh

Can we uplift a fix for this to 70?

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #9097089 - Attachment description: Bug 1583398 - Mock LoginBreaches.getPotentialBreachesByLoginGUID to stop all of the fxmonitor logspam when running aboutlogins mochitest-browser tests. r?MattN → Bug 1583398 - Store breaches in the remote store for tests when expected, and otherwise prevent all of the fxmonitor logspam when running aboutlogins mochitest-browser tests. r?MattN
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50831ea2e7d9
Newly added logins should show breach notifications if they apply. r=MattN
https://hg.mozilla.org/integration/autoland/rev/a0e7d3f142e5
Move error rendering to the render function so calling render is idempotent. r=MattN
https://hg.mozilla.org/integration/autoland/rev/dcffd1555e69
Store breaches in the remote store for tests when expected, and otherwise prevent all of the fxmonitor logspam when running aboutlogins mochitest-browser tests. r=MattN

I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20191003214801) on Windows 7 x64, Mac 10.14, Arch Linux 4.12.

  • The breached logins are correctly displayed after importing logins from Chrome without refreshing the page.
  • The breached logins are correctly displayed after syncing logins without refreshing the page.
Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch

I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10 x64, Mac 10.14, Arch Linux 4.12. .

  • The breached logins are correctly displayed after importing logins from Chrome without refreshing the page.
  • The breached logins are correctly displayed after syncing logins without refreshing the page.
status-firefox70: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: