Imported logins do not display breach indicators without refresh
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox69 | --- | disabled |
firefox70 | --- | verified |
firefox71 | --- | verified |
People
(Reporter: ssage, Assigned: jaws)
Details
(Whiteboard: [passwords:management] [skyline])
Attachments
(3 files)
When I imported my credentials from Chrome, I did not see any breached results (no indicators, no dropdown option to find them). Upon refreshing the about:logins view, I found 2 breached accounts, displaying as expected.
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
I believe this is because we don't compute the breached logins upon storage changes like addLogin
, only when we're sending all logins. This problem would also happen if about:logins is open while sync downloads new logins from another client.
Comment 2•5 years ago
|
||
Can we uplift a fix for this to 70?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50831ea2e7d9 Newly added logins should show breach notifications if they apply. r=MattN https://hg.mozilla.org/integration/autoland/rev/a0e7d3f142e5 Move error rendering to the render function so calling render is idempotent. r=MattN https://hg.mozilla.org/integration/autoland/rev/dcffd1555e69 Store breaches in the remote store for tests when expected, and otherwise prevent all of the fxmonitor logspam when running aboutlogins mochitest-browser tests. r=MattN
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/50831ea2e7d9
https://hg.mozilla.org/mozilla-central/rev/a0e7d3f142e5
https://hg.mozilla.org/mozilla-central/rev/dcffd1555e69
Comment 8•5 years ago
|
||
I have verified this issue and is no longer reproducible on the latest Nightly 71.0a1 (Build ID: 20191003214801) on Windows 7 x64, Mac 10.14, Arch Linux 4.12.
- The breached logins are correctly displayed after importing logins from Chrome without refreshing the page.
- The breached logins are correctly displayed after syncing logins without refreshing the page.
Assignee | ||
Comment 9•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Comment 10•5 years ago
|
||
I have verified this issue on the Firefox Beta 70.0b13 (Build ID: 20191007220302) on Windows 10 x64, Mac 10.14, Arch Linux 4.12. .
- The breached logins are correctly displayed after importing logins from Chrome without refreshing the page.
- The breached logins are correctly displayed after syncing logins without refreshing the page.
Description
•