1583457 - ConsoleProgressListener is never used/tested with MONITOR_LOCATION_CHANGE

Status: RESOLVED FIXED

(DevTools :: Console, task, P3)

Description

[Julian Descottes [:jdescottes]]

While reviewing mentions of window.top in scope of Bug 1583444, I spotted the following comment:

  /**
   * Check if the current window.top location is changing, given the arguments
   * of nsIWebProgressListener.onStateChange. If that is the case, the remote
   * Web Console instance is notified.
   * @private
   */
  _checkLocationChange: function(progress, request, state) {
[...]
}

https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole/listeners/console-progress.js#183-209

But the method itself is not using window.top at any point.

This was introduced a very long time ago: https://bugzilla.mozilla.org/show_bug.cgi?id=673148

It is only used if you call ConsoleProgressListener::startMonitor(2) (2 is the value of ConsoleProgressListener.MONITOR_LOCATION_CHANGE), but:

• coverage data shows the function is untested
• searchfox for startMonitor( leads to only one callsite: https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/devtools/server/actors/webconsole.js#782-784 which doesn't use MONITOR_LOCATION_CHANGE, but MONITOR_FILE_ACTIVITY

I think we should remove this unused codepath

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1583457 - Remove unused MONITOR_LOCATION_CHANGE option from ConsoleProgress

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2769fdb65549
Remove unused MONITOR_LOCATION_CHANGE option from ConsoleProgress r=nchevobbe

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2769fdb65549