Closed Bug 1583487 Opened 3 months ago Closed 2 months ago

Remove Baseline's WarmUpCount IC

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(3 files)

We never attach any stubs to this IC so it could just be a plain VM call and/or trampoline code. Furthermore, the Baseline Interpreter doesn't use this IC at all and it's not very nice to have this JIT-specific IC in JitScript.

Bug 1583172 touches this code too so let's wait for that to land first.

Depends on: 1583172
Priority: -- → P3

This lets us simplify the calling code because the VMFunction wrapper code now does
the right thing.

We never attached stubs to this and the Baseline Interpreter does not use this IC at all
so it's nicer and simpler to use a plain VM call.

Depends on D47880

  • Store the pointer in JitRuntime instead of JSContext.

  • Use UniquePtr for this pointer. I think this may also fix a memory leak
    (when realloc failed we didn't free the old allocation).

  • Call it ionOsrTempData instead of osrTempData.

  • Use placement new and remove an unnecessary memset.

Depends on D47881

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed2fda501785
part 1 - Make VMFunction wrapper treat IonOsrTempData** as outparam. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/47830868674f
part 2 - Remove Baseline's WarmUpCount IC, use a plain VM call instead. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/989b75468b7e
part 3 - Clean up IonOsrTempData code a bit. r=tcampbell
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.