Closed Bug 1583491 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 19248 - Restrict 'keySplines' x-values to the [0, 1] range

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19248 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19248
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Restrict 'keySplines' x-values to the [0, 1] range

Per SMIL[1], all the values in a key spline should be within [0, 1], but
to be consistent with CSS' timing function, allow y-values to be outside
that range (at least for now).

While in ParseKeySplinesInternal(...), rename the |pos_*| local
variables to something that carries a little bit more semantic meaning.

[1] https://www.w3.org/TR/SMIL3/smil-animation.html#adef-keySplines

Bug: 1006544
Change-Id: I6baa4085943eca8144605fb0a5c442bc8486ad87
Reviewed-on: https://chromium-review.googlesource.com/1821158
WPT-Export-Revision: a2b84ed866616784684a9ed35835548e5b6a2eb1

Component: web-platform-tests → SVG
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df5cfec33061
[wpt PR 19248] - Restrict 'keySplines' x-values to the [0, 1] range, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.