158352 - Editor functionality crashes MfcEmbed

Status: VERIFIED INVALID

(Core :: DOM: Editor, defect)

Description

[Chak Nanga]

1. Run MfcEmbed and choose "New Editor Window".
2. Type in a few characters into the editor
3. Click on the "B" toolbar button
4. Crashes

This used to work fine and seems to have been broken as part of the checkins for
#125146.

Comment 1

[Chak Nanga]

Attachment: Pass in a valid nsICommandParams instead of a zero

Possible fix. Should'nt we be passing in a valid nsICommandParams instead of a
zero like it's being done now?

Comment 2

[Simon Fraser [no longer active]]

No. Passing a null nsICommandParams should be legal for some commands.

Comment 3

[Chak Nanga]

Just realized that the prev. patch will not cover all the cases. Looking at the
code we may have other potential crashes. For ex, in:

CEditorFrame::ExecuteNoParam(const char *aCommand)
{
    return DoCommand(aCommand,0); //<---Passing in 0 here is bad. It will crash.
}

Comment 4

[Chak Nanga]

Hi Simon : Let me see if i can get a stack trace....thanks

Comment 5

[amutch]

Interesting. I've neved been able to get the editor component to work in MFCEmbed. 

Comment 6

[amutch]

Trying this on WindowsXP with the 7/19/2002 nightly of MFCEmbed and I can't type
anything into the editor window. This has been a fairly consistent behavior of
the nightly builds for sometime. Does the nightly not include the necessary
files to actually use the editor component?

Comment 7

[Simon Fraser [no longer active]]

> Does the nightly not include the necessary files to actually use the editor
component?

That's possible. I believe that the emebedding manifest fails to include the
composer DLL.

Comment 8

[mjudge]

crashes.. this parameter that isnt necessary should definately not be crashing.  
for no parameters now you are supposed to pass in null for the commandparams.  
if you get a stack trace please let me know 

Comment 9

[Chak Nanga]

i tested with my latest trunk builds and it does NOT crash anymore.

Wonder if something was horked with my (old) source tree. I recently pulled a
fresh copy from CVS when i switched to gmake builds.

Marking INVALID

Comment 10

[sujay]

verified.