1583534 - Further simplify PresShell::ResizeReflow.

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Preparation cleanup for my fix for bug 1551659.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1583534 - Further simplify PresShell::ResizeReflow.

In particular, not let ResizeReflow take the old and new size. Most of the
callers pass dummy values anyway.

Instead, use the old size of the layout viewport. This ensures we fire resize
events only if the layout viewport actually changes.

To do this, we need to shuffle a bit of code in nsDocumentViewer that deals with
delayed resizes, to set the visible area and invalidate layout, rather than
setting the visible area and then relying on doing a resize reflow.

Further cleanup is possible, though not required for my android resizing fix, so
will do separately.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Android: https://treeherder.mozilla.org/#/jobs?repo=try&revision=16f6b0a5870c96291c3703c741118db52e82c9ef
Desktop: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a40c8071e606fccd4293ad0b3dad54719fcdd6f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7180808eaae
Further simplify PresShell::ResizeReflow. r=botond

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a7180808eaae