Closed Bug 1583534 Opened 21 days ago Closed 20 days ago

Further simplify PresShell::ResizeReflow.

Categories

(Core :: Layout, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Preparation cleanup for my fix for bug 1551659.

In particular, not let ResizeReflow take the old and new size. Most of the
callers pass dummy values anyway.

Instead, use the old size of the layout viewport. This ensures we fire resize
events only if the layout viewport actually changes.

To do this, we need to shuffle a bit of code in nsDocumentViewer that deals with
delayed resizes, to set the visible area and invalidate layout, rather than
setting the visible area and then relying on doing a resize reflow.

Further cleanup is possible, though not required for my android resizing fix, so
will do separately.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7180808eaae
Further simplify PresShell::ResizeReflow. r=botond
Status: NEW → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.