1583535 - The Megabar should not expand when auto-focused after a panel is closed

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Harry Twyford]

If the megabar is expanded, a click on an identity icon or a page action icon will collapse it. Clicking on an icon again will expand it. Continued clicks on icons loop collapse/expansion. This is inconsistent, especially seeing as clicking on these icons when the megabar is collapsed never expands it.

Verdi, could you please clarify what the expected behaviour is here? If the megabar is expanded and an icon is clicked, should the megabar collapse and subsequent icon clicks keep it collapsed? Or should it stay expanded no matter how many icons are clicked? What should happen when icons are clicked when the megabar is collapsed?

Comment 1

[Harry Twyford]

Currently, if the Urlbar is focused and the user clicks an identity icon, we blur the Urlbar. If the icon is clicked again to hide the doorhanger, we re-focus the Urlbar but at the beginning of the string (not where the cursor was previously). This might be a good opportunity to fix this slightly weird behaviour. For example, we could select the entire string when the identity icon is clicked the second time, instead of putting the cursor at the beginning.

Comment 2

[Verdi [:verdi] Best to slack me]

(In reply to Harry Twyford [:harry] from comment #0)

Verdi, could you please clarify what the expected behaviour is here? If the megabar is expanded and an icon is clicked, should the megabar collapse and subsequent icon clicks keep it collapsed? Or should it stay expanded no matter how many icons are clicked?

Yes, we should use the "focused and collapsed" state here. The bar should remain that way until the user focuses it again (clicks back inside, uses keyboard shortcut, starts typing a URL, etc.).

What should happen when icons are clicked when the megabar is collapsed?

It should remain in it's current state whether that's "unfocused & collapsed" or "focused and collapsed."

(In reply to Harry Twyford [:harry] from comment #1)

Currently, if the Urlbar is focused and the user clicks an identity icon, we blur the Urlbar. If the icon is clicked again to hide the doorhanger, we re-focus the Urlbar but at the beginning of the string (not where the cursor was previously). This might be a good opportunity to fix this slightly weird behaviour. For example, we could select the entire string when the identity icon is clicked the second time, instead of putting the cursor at the beginning.

Yes, let's do that — select the entire string when the identity icon is clicked the second time.

Comment 3

[Harry Twyford]

Attachment: Bug 1583535 - Enter Focused & Collapsed state after repeated clicks on Urlbar icons. r?dao

Comment 4

[Harry Twyford]

I just spoke with Verdi. He clarified that we should enter the Focused & Collapsed state when exiting any panel that results in an Urlbar auto-focus event, not just identity/bookmarks/protections panels.

For example, if the Urlbar is focused and the user opens then closes the Library panel, we should refocus the Urlbar (as we do now) but not expand it. This might require changes higher up the line than UrlbarInput. Maybe setting a flag in the focus handlers in popup.xml?

Comment 5

[Harry Twyford]

Attachment: Bug 1583535 - The Megabar should not expand when auto-focused after a panel is closed. r?dao

Depends on D48104

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8804b063e85a
The Megabar should not expand when auto-focused after a panel is closed. r=dao

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8804b063e85a