1583546 - Ensure that pausing on a breakpoint without the debugger open is covered by a test

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

While reviewing bug 1578408, it appears that this particular usecase may not be covered by any test.
Toolbox.isToolHighlighter isn't used by any debugger test:
https://searchfox.org/mozilla-central/search?q=isToolHigh&case=false&regexp=false&path=devtools%2F
Nor do we try to check "highlighted" classname of any DOM Element:
https://searchfox.org/mozilla-central/search?q=%22highlighted%22&case=false&regexp=false&path=devtools%2F

I may not used the right search string?

In case, such test exists, it would be great to augment it in order to cover breaking from an <iframe> using another domain, so that we can verify that this feature works with Fission.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1583546 - Add test that the OBT debugger can pause even when it hasn't been opened, r=ochameau.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f5359d5db86
Add test that the OBT debugger can pause even when it hasn't been opened, r=ochameau.

Comment 3

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=273910461&resultStatus=testfailed%2Cbusted%2Cexception&revision=9f5359d5db8611f0e0fb1dbfbd806dea42b8cb38

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=273920963&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=273920205&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/550f1231a4ca6d01b76e3d5165e4568eec6a1029

[task 2019-10-31T15:33:44.081Z] 15:33:44 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js | source url found ("http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js") -
[task 2019-10-31T15:33:44.081Z] 15:33:44 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js | expected source url -
[task 2019-10-31T15:33:44.081Z] 15:33:44 INFO - Buffered messages finished
[task 2019-10-31T15:33:44.081Z] 15:33:44 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js | The textarea of logpoint panel is focused - Got BODY, expected TEXTAREA
[task 2019-10-31T15:33:44.081Z] 15:33:44 INFO - Stack trace:
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochikit/content/browser-test.js:test_is:1314
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:checkClickOnNode:531
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:testOpenInDebugger:455
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js:null:53
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:537 - TypeError: inputEl.parentElement.parentElement is null
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - Stack trace:
[task 2019-10-31T15:33:44.082Z] 15:33:44 INFO - checkClickOnNode@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:537:24
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - asynctestOpenInDebugger@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/head.js:455:9
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - async@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_location_logpoint_debugger_link.js:53:9
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1069:34
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:932:14
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - Leaving test bound
[task 2019-10-31T15:33:44.083Z] 15:33:44 INFO - Entering test bound
[task 2019-10-31T15:33:44.084Z] 15:33:44 INFO - GECKO(1810) | [ACTION] SET_BREAKPOINT [done] - {"type":"SET_BREAKPOINT","cx":{"navigateCounter":0},"breakpoint":{"id":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js:7:12","disabled":false,"options":{"logValue":"undefinedVariable"},"location":{"line":7,"column":12,"sourceId":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js","sourceUrl":"http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js"},"astLocation":{"name":"add","offset":{"line":1},"index":0},"generatedLocation":{"line":7,"column":12,"sourceId":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js","sourceUrl":"http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js"},"text":"1;","originalText":"1;"},"seqId":"9","status":"done","value":[null]}
[task 2019-10-31T15:33:44.084Z] 15:33:44 INFO - GECKO(1810) | [ACTION] SET_BREAKPOINT [done] - {"type":"SET_BREAKPOINT","cx":{"navigateCounter":0},"breakpoint":{"id":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js:8:12","disabled":false,"options":{"logValue":"`a is ${a}`"},"location":{"line":8,"column":12,"sourceId":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js","sourceUrl":"http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js"},"astLocation":{"name":"add","offset":{"line":2},"index":0},"generatedLocation":{"line":8,"column":12,"sourceId":"sourceURL-http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js","sourceUrl":"http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint-1.js"},"text":"2;","originalText":"2;"},"seqId":"10","status":"done","value":[null]}
[task 2019-10-31T15:33:44.085Z] 15:33:44 INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/webconsole/test/browser/test-location-debugger-link-logpoint.html
[task 2019-10-31T15:33:44.230Z] 15:33:44 INFO - Tab added and finished loading
[task 2019-10-31T15:33:44.230Z] 15:33:44 INFO - Opening the toolbox
[task 2019-10-31T15:33:44.412Z] 15:33:44 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-31T15:33:44.479Z] 15:33:44 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-31T15:33:44.562Z] 15:33:44 INFO - Toolbox opened and focused
[task 2019-10-31T15:33:44.562Z] 15:33:44 INFO - Open the Debugger panel
[task 2019-10-31T15:33:44.770Z] 15:33:44 INFO - GECKO(1810) | [ACTION] SET_ORIENTATION - {"type":"SET_ORIENTATION","orientation":"horizontal"}
[task 2019-10-31T15:33:44.770Z] 15:33:44 INFO - GECKO(1810) | [ACTION] UPDATE_EVENT_LISTENERS - {"type":"UPDAT

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df564ab5211e
Add test that the OBT debugger can pause even when it hasn't been opened, r=ochameau.

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/df564ab5211e