Closed Bug 1583621 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 19267 - Fix xrWebGLLayer_constructor test

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19267 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19267
Details from upstream follow.

Alex Cooper <alcooper@chromium.org> wrote:

Fix xrWebGLLayer_constructor test

xrWebGLLayer_constructor was mistakenly updated to require user
activation though the spec does not explicitly require it in this case
since the inline session does not request any features. Even were it
to require this, the way that it was structured caused there to not be
a promise set when the ".then" was caused, giving a scrit error.

This change essentially reverts WPT Commit 16d4388, and was discussed
with Mozilla when deciding which way to fix it.

Bug:1007304
Change-Id: I824f63cb172aed5928c55224b31c00803b5ddaa2
Reviewed-on: https://chromium-review.googlesource.com/1822821
WPT-Export-Revision: df50d531063cdc8998112f73953fded5b194e198

Ran 1 tests and 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt] subtests OK : 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt] FAIL : 1[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt] Tests that are disabled for instability: /webxr/xrWebGLLayer_constructor.https.html: [android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e39bf59dbf6 [wpt PR 19267] - Fix xrWebGLLayer_constructor test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5e39bf59dbf6

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.