1583700 - Enable DocumentChannel by default in Nightly

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Neha Kochar [:neha]]

This is to track pref'ing ON DocumentChannel (browser.tabs.documentchannel) by default.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Move CSP setup code to run in both processes. r?nika

We want this to run in both processes so that we set the cspToInherit on the LoadInfo within the child as well as the parent.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Make DocumentChannelParent::HasCrossOriginOpenerPolicyMismatch return the union of the state from all channels we redirected through. r?nika

Depends on D47355

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Update WPT expectations. r?nika

Depends on D47356

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Enable DocumentChannel by default. r?nika

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Pass the loading context of the cspToInherit when deserializing LoadInfo, since this isn't necessarily the same as the loading context of the LoadInfo. r?nika

Depends on D47358

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e63705922847900e0f0e0c53d630153abfa8c2f

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Create a new ClientSource from a parent-allocated ClientInfo even for same-origin redirects, since there might have been a prior cross-origin redirect. r?Perry,asuth

Comment 8

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Copy hasNonEmptySandboxingFlags across with DocumentChannel so that it can be set on the nHttpChannel in the parent. r?JuniorHsu,valentin

Depends on D49870

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d06db6d43c
Enable DocumentChannel by default. r=nika
https://hg.mozilla.org/integration/autoland/rev/cfb571dd120a
Move CSP setup code to run in both processes. r=nika,ckerschb,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/015ec42c311a
Make DocumentChannelParent::HasCrossOriginOpenerPolicyMismatch return the union of the state from all channels we redirected through. r=nika
https://hg.mozilla.org/integration/autoland/rev/41e07201a158
Update WPT expectations. r=perry
https://hg.mozilla.org/integration/autoland/rev/dc9e317da307
Pass the loading context of the cspToInherit when deserializing LoadInfo, since this isn't necessarily the same as the loading context of the LoadInfo. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/c662a369062f
Create a new ClientSource from a parent-allocated ClientInfo even for same-origin redirects, since there might have been a prior cross-origin redirect. r=perry,asuth
https://hg.mozilla.org/integration/autoland/rev/48ceb0dd5d09
Copy hasNonEmptySandboxingFlags across with DocumentChannel so that it can be set on the nHttpChannel in the parent. r=JuniorHsu,valentin

Comment 10

[Alexandru Michis [:malexandru]]

Backed out 7 changesets (Bug 1583700) for causing raptor dom failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1800de9be60f5747964112065197010207bfde87

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2Cx64%2Cshippable%2Copt%2Craptor%2Cperformance%2Ctests%2Con%2Cfirefox%2Ctest-linux64-shippable%2Fopt-raptor-assorted-dom-firefox-e10s%2Crap%28dom%29&fromchange=ef22242bd8198887b592a40e09fb9fc851732d58&tochange=e528f32390b25793f780b90f05e943dd3c02065d&selectedJob=272299379

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272299379&repo=autoland&lineNumber=950

[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - raptor-control-server Info: received webext_raptor-page-timeout: [u'raptor-assorted-dom-firefox', u'http://127.0.0.1:37263/assorted-dom/assorted/driver.html?raptor']
[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - PID 3484 | console.error: "raptor-page-timeout on http://127.0.0.1:37263/assorted-dom/assorted/driver.html?raptor"
[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - PID 3484 | console.log: "[raptor-runnerjs] posting to control server"
[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - PID 3484 | console.log: "[raptor-runnerjs] raptor-assorted-dom-firefox,http://127.0.0.1:37263/assorted-dom/assorted/driver.html?raptor"
[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - PID 3484 | console.log: "[raptor-runnerjs] capturing screenshot"
[task 2019-10-22T00:19:18.755Z] 00:19:18 INFO - PID 3484 | console.log: "[raptor-runnerjs] post success"
[task 2019-10-22T00:19:18.791Z] 00:19:18 INFO - raptor-control-server Info: received webext_screenshot
[task 2019-10-22T00:19:18.791Z] 00:19:18 INFO - perftest-results-handler Info: received screenshot
<...>
[task 2019-10-22T00:19:20.822Z] 00:19:20 ERROR - raptor-main Critical: TEST-UNEXPECTED-FAIL: no raptor test results were found for raptor-assorted-dom-firefox
[task 2019-10-22T00:19:20.891Z] 00:19:20 ERROR - Return code: 1

Comment 11

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1583700 - Listen for DocumentChannel's on-opening-request as well as HTTP's in ExtensionPolicyService.

Comment 12

[Matt Woodrow (:mattwoodrow)]

This failure is a bit crazy.

The raptor extension is injecting a content script in DOMContentLoaded, but the extension service code for doing so is an async function with awaits (for scripts to compile).

The injected script adds a listener for messages, and the test itself sends a message with the results from the load event.

We require that the content scripts run and install the listener, before the load event.

This race is usually won, because ExtensionPolicyService.cpp has an http-on-opening-request listener, which precompiles scripts. When we get DOMContentLoaded, these should all be ready (hopefully?), so the async function should run sync.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5768c2f8124
Enable DocumentChannel by default. r=nika
https://hg.mozilla.org/integration/autoland/rev/7ff126a6e02a
Move CSP setup code to run in both processes. r=nika,ckerschb,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/5a36f774f015
Make DocumentChannelParent::HasCrossOriginOpenerPolicyMismatch return the union of the state from all channels we redirected through. r=nika
https://hg.mozilla.org/integration/autoland/rev/7241ab9853a7
Update WPT expectations. r=perry
https://hg.mozilla.org/integration/autoland/rev/57e190b02a52
Pass the loading context of the cspToInherit when deserializing LoadInfo, since this isn't necessarily the same as the loading context of the LoadInfo. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/b11ead7ebf7b
Create a new ClientSource from a parent-allocated ClientInfo even for same-origin redirects, since there might have been a prior cross-origin redirect. r=perry,asuth
https://hg.mozilla.org/integration/autoland/rev/a30fe09fc6be
Copy hasNonEmptySandboxingFlags across with DocumentChannel so that it can be set on the nHttpChannel in the parent. r=JuniorHsu,valentin
https://hg.mozilla.org/integration/autoland/rev/25b533bff405
Listen for DocumentChannel's on-opening-request as well as HTTP's in ExtensionPolicyService. r=jya

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d5768c2f8124
https://hg.mozilla.org/mozilla-central/rev/7ff126a6e02a
https://hg.mozilla.org/mozilla-central/rev/5a36f774f015
https://hg.mozilla.org/mozilla-central/rev/7241ab9853a7
https://hg.mozilla.org/mozilla-central/rev/57e190b02a52
https://hg.mozilla.org/mozilla-central/rev/b11ead7ebf7b
https://hg.mozilla.org/mozilla-central/rev/a30fe09fc6be
https://hg.mozilla.org/mozilla-central/rev/25b533bff405