Closed Bug 1583728 Opened 6 months ago Closed 6 months ago

Migrate <page> to <window> before its removal in bug 1583377

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1583377 removes the xul|page. We still use it and need to migrate it to xul|window.

On Windows I see no change to before.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9095080 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9095080 [details] [diff] [review]
1583728-page-to-window-migration.patch

Review of attachment 9095080 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah looks ok on linux too. 

You missed a couple though:
./mail/components/compose/content/MsgComposeCommands.js:      // onload event of <page id="abContactsPanel">, in AbPanelLoad() of
./mail/base/test/browser/files/menulist.xul:<page align="start" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml">

r=mkmelin with those fixed
Attachment #9095080 - Flags: review?(mkmelin+mozilla) → review+

And what's about https://searchfox.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#6955 ? Should I change the parameter from page to window too?

Attachment #9095080 - Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Attachment #9095092 - Flags: review+

I think yes, to avoid confusion.

Flags: needinfo?(mkmelin+mozilla)

Changed the parameter to aWindowId.

Attachment #9095092 - Attachment is obsolete: true
Attachment #9095099 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7eda6c6992b8
Port bug 1583377: Migrate xul:page to xul:window. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.