1583845 - The hover state from the CTA button from a sponsored card is wrongly the same as the pressed state

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andreea Cupsa [:acupsa], Experiments QA]

Attachment: Hover and pressed state the same for the CTA button.gif

[Affected versions]:

• Firefox Beta 70.0b9, Build ID: 20190923154733
• Firefox Nightly 71.0a1, Build ID: 20190925095053

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a new Firefox profile with the following preferences set:
  • browser.search.region to US
• browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
• browser.newtabpage.activity-stream.discoverystream.endpoints to https://,http://
• browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://gist.githubusercontent.com/punamdahiya/0add5e6e4807d31717eb693d2e0f387d/raw/76b452765a0da75c57917da6531ff4cb2ebe86ab/stage-cta-link.json"}

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Open a new tab.
3. Hover the CTA button from a sponsored card.
4. Observe the behavior of the button.
5. Click and hold on the CTA button from a sponsored card.
6. Observe the behavior of the button.

[Expected result]:
Step 4 & 6. There is a difference between the hover and the pressed state of the button.

[Actual result]:
Step 4 & 6. The hover and the pressed state are the same.

[Notes]:

• According to the design specifications the hover and pressed state should have different color codes. When inspecting the button and checking the states, the :hover and :active states background color codes are the same. The hover state wrongly has the color code of the pressed state.
• Attached a screen recording with the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5357

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Note: To see a CTA button you'll now need to use this value for browser.newtabpage.activity-stream.discoverystream.config

{"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":false,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1583845-layout"}

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/40a815ecfbe3

Comment 4

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue is no longer reproducible on the Latest Firefox Nightly 72.0a1 (Build ID: 20191107215315) on Windows 10 x64, Mac 10.14.6 and Arch Linux.