1583849 - WIP Phabricator revisions not moved out of Draft state

Status: NEW

(bugzilla.mozilla.org :: Phabricator Integration, defect, P2)

Description

[:glob ✱]

Revisions submitted as WIP (eg. with moz-phab submit --wip) are not being moved out of the Draft state by PhabBugz.

Examples:

• https://phabricator.services.mozilla.com/D47032
• https://phabricator-dev.allizom.org/D1355

In both cases phab-bot updated the visibility, but didn't move it out of Draft.

I thought this was fixed in Bug 1555409, where we decided that phab-bot should always move a revision out of draft when it has finished processing. This is because we're using Draft to indicate if phab-bot has completed processing a revision, not if it's in work-in-progress (that's covered by "changes planned").

Comment 1

[Marcia Knous [:marcia]]

dkl: I keep getting bugzilla emails for Bug 1584215 every few minutes - I assume this is because of this issue? Alastor mentioned an issue with Phabricator in the bug. The emails all look like:

Created attachment 9096681

The request is used to track if the promise is resolved or not, so we should call its Complete() method once promise is resolved, in order to keep the state of the request correct.

Comment 2

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request