1583868 - Perma GTest GeckoProfiler.Markers | Value of: strstr(profile.get(), okstr1.get()) when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Cristina Coroiu [:ccoroiu]]

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1e201ab2a6431ff279bda043a26c927d2188c7c7&selectedJob=268353139

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=268353139&repo=try&lineNumber=26201

task 2019-09-25T13:08:51.787Z] 13:08:51 INFO - TEST-START | GeckoProfiler.Markers
[task 2019-09-25T13:08:52.461Z] 13:08:52 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.Markers | Value of: strstr(profile.get(), okstr1.get())
[task 2019-09-25T13:08:52.461Z] 13:08:52 INFO - Actual: false
[task 2019-09-25T13:08:52.461Z] 13:08:52 INFO - Expected: true @ /builds/worker/workspace/build/src/tools/profiler/tests/gtest/GeckoProfiler.cpp:654
[task 2019-09-25T13:08:52.461Z] 13:08:52 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.Markers | test completed (time: 673ms)
[task 2019-09-25T13:08:52.461Z] 13:08:52 INFO - TEST-START | GeckoProfiler.DurationLimit
[task 2019-09-25T13:08:54.178Z] 13:08:54 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.DurationLimit | Expected equality of these values:
[task 2019-09-25T13:08:54.178Z] 13:08:54 INFO - GTestMarkerPayload::sNumDeserialized
[task 2019-09-25T13:08:54.178Z] 13:08:54 INFO - Which is: 2
[task 2019-09-25T13:08:54.179Z] 13:08:54 INFO - 1 @ /builds/worker/workspace/build/src/tools/profiler/tests/gtest/GeckoProfiler.cpp:750
[task 2019-09-25T13:08:54.179Z] 13:08:54 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.DurationLimit | test completed (time: 1740ms)

Comment 1

[Raul Gurzau (:RaulG)]

These seem to happen only on OS X 10.14 : https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=268763035&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=26abff1606696df3e2dea55cca0f02d835e0b826&searchStr=gtest

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I can confirm that this is due to bug 1549482:

• On Mac, stack walking availability is dependent on MOZ_PROFILING, which is only defined by default on Nightly (because frame pointers are needed, and are only available on Nightly), hence the resulting issue when moving to beta.
• Some tests only enable the "StackWalk" feature (e.g., Profiler.Markers), which gets effectively disabled because stack walking is not available on beta/Mac.
• Bug 1549482 "cleverly" assumed that no StackWalk/Leaf/Javascript meant the user was not interested in capturing backtraces, in which the misnamed Profiler.Markers test expects to find labels.

It would be possible to just add the "Leaf" feature to force backtraces, but I'm afraid that other tests may also rely on this (e.g., possibly bug 1584976), so I will revert part of bug 1549482, and instead add a new feature -- that was discussed as an alternative anyway, which will be less surprising to tests and people.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Beta-try shows that the proposed patch solves this issue:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=87f20a99c034c35ccd8edf94b04900c4546d1f01

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1583868 - New profiler feature "nostacksampling" - r?gregtatum

Previously, the absence of "stackwalk", "leaf", and "javascript" implied that
the test/user didn't want any sampling, but this caused issues in some tests
that enabled "stackwalk" on platforms that didn't support stack-walking, which
ended up suppressing label-only stacks that the test expected.

we now have an explicit feature "nostacksampling" that disables backtraces from
the samplers in both profilers. This effectively cancels "stackwalk", "leaf",
and "javascript" if present.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8989d1a83de8
New profiler feature "nostacksampling" - r=gregtatum

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 8989d1a83de8 (Bug 1583868) for xpcshell failures at test_ext_geckoProfiler_schema.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/806c059d195af1843a9dd13c805869fd6aa49871

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=8989d1a83de8378133d594ca8ab3f4cd8feadcd5&selectedJob=269281652

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269281652&repo=autoland&lineNumber=6458

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad006751f4e4
New profiler feature "nostacksampling" - r=gregtatum

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ad006751f4e4

Comment 9

[Andreea Pavel [:apavel]]

Verified fix in recent beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b6507172914b14d3270456c80ee292abfc3994da&searchStr=gtest