1583879 - Detect and skip empty blob tiles

Status: NEW

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Nicolas Silva [:nical]]

The none of the blob item bounds intersect the tile, we can avoid uploading and rendering it. This would help in a number of cases (for example bug 1566912, bug 1580864).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1583879 - Skip uploading and rendering empty blob tiles. r=jrmuizel

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Did you see this helping on the sites you mentioned?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Also, it might be worth only testing with the patch from bug 1582210 applied as that will get rid of a large source of empty tiles.

Comment 4

[Nicolas Silva [:nical]]

The blob splitting change obsoleted this patch for a lot of the test cases. There is bug 1484863 for which this still helps quite a bit. We have rather large layers with animated transforms and the items on these layers are far enough appart that there are a number of empty tiles in the middle.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d3ccf69629
Skip uploading and rendering empty blob tiles. r=jrmuizel

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out changeset 42d3ccf69629 (bug 1583879) for causing reftest failures on sort-startSame-1b.svg CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/d19d644cb240a27a1d0389a0ca603b4bbffddd42

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=42d3ccf69629e077b151538a9aad733f82a52a0c&searchStr=reftest

Log failures https://treeherder.mozilla.org/logviewer.html#?job_id=270889333&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=270889903&repo=autoland

Nicolas can you please take a look?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nical, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Glenn Watson [:gw]]

Nical, is this still relevant?

Comment 9

[Nicolas Silva [:nical]]

I think so, although not necessarily super high profile.