Closed Bug 1583912 Opened 4 years ago Closed 4 months ago

[Inactive CSS] Display a warning when column-related properties are used on non-multi-column containers

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
enhancement

Tracking

(firefox118 fixed)

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: miker, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed, Whiteboard: [importance-0.8%])

Attachments

(1 file)

Bug 1583912 - [devtools] Handle ignored properties in non-multi-column containers in inactive CSS. r=#devtools-reviewers.
48 bytes, text/x-phabricator-request
Details | Review

Main file:
devtools/server/actors/utils/inactive-property-helper.js

invalidProperties: [
"column-fill",
"column-rule",
"column-rule-color",
"column-rule-style",
"column-rule-width",
]

inactive-css-column-fill = <strong>{ $property }</strong> has no effect on this element since it can only be applied to multi-column containers.

inactive-css-column-fill-fix = Try adding <strong>column-count</strong> to the element. { learn-more }

Severity: normal → S3
Summary: [Inactive CSS] Display a warning when 'column-fill' is used on non-multi-column containers → [Inactive CSS] Display a warning when column-related properties are used on non-multi-column containers
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Pushed by sebastianzartner@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7879625d4e17
[devtools] Handle ignored properties in non-multi-column containers in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.

https://hg.mozilla.org/mozilla-central/rev/7879625d4e17

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch

This might be worth being mentioned in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/118 together with the changes of bug 1842174 and bug 1583906.

Sebastian

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.