1583957 - input autocomplete property is empty for username/new-password/current-password values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Dave Lockhart]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36

Steps to reproduce:

1. Create a <input type="text" autocomplete="username"> element
2. In JavaScript, get the element and access its "autocomplete" property (e.g. document.getElementById('elem').autocomplete).

Actual results:

The value of the property is the empty string.

Expected results:

The property should be "username" like it is in other browsers, and like it is if you call "getAttribute('autocomplete')".

Comment 1

[Virginia (please send need info request to Brindusa Tot)]

Hi Dave,

Thanks for reporting this bug.

Could you please share with us a test page and further steps so we can test this on our end?

Please also let us know if you can reproduce the issue by testing on the latest Firefox Nightly version, you can download it from here: https://nightly.mozilla.org/.

Thanks!

Comment 2

[Dave Lockhart]

Hi Virginia,

Here's a test page that demonstrates the issue:
https://codepen.io/dlockhart/pen/JjjXeYO?editors=1111

I can confirm the issue in Firefox 69.0.3 and in the Nightly version 71.

Comment 3

[Virginia (please send need info request to Brindusa Tot)]

Hi Dave,

Thanks for providing us with the test page.

I was able to reproduce it on Firefox Nightly 72.0a1 (2019-10-22) (64-bit) on Mac OSX 10.14 and Windows 10.

I'll add a product and component so the corresponding dev team can take a look at this.

Regards,

Comment 4

[Matthew N. [:MattN]]

Hi Dave, it's been a long time since my internship at D2L in 2008 👋

This was intentional to support feature detection by web developers since we didn't use this value for anything until bug 917325 (Fx67). At that point it should have been made available. I will also fix a similar issue for new-password which we use since bug 1119063 (Fx67).

You can see the list of other autocomplete token values that we don't support.

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c6375cd9adb
Indicate support for autocomplete=(username|new-password|current-password). r=farre

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 9103734 [details]
Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre

Beta/Release Uplift Approval Request

• User impact if declined: Site that rely on element.autocomplete to return non-empty values for username/new-password/current-password may be broken. This is useful to fix since we recently started supporting these tokens.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch to indicate that an autocomplete token is now supported.
• String changes made/needed: None

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6c6375cd9adb

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9103734 [details]
Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre

Low risk patch with tests early in the beta cycle, uplift approved for 71 beta 5, thanks!

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f91bfc4b026

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to nominate for ESR68 too? It grafts cleanly as-landed.

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 9103734 [details]
Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre

It would be nice since the bugs that regressed this went in 67 but this is the only report I've seen about the issue so I don't think it's pressing. It could help sites to not require fallbacks to input.getAttribute("autocomplete") (which has different behaviour). Up to you.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Improve web compatibility by aligning with Blink/Webkit on these autocomplete token values.
• User impact if declined: Potential incorrect behaviour of website JS related to username/password fields.
• Fix Landed on Version: 71.0.0
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch to indicate that an autocomplete token is now supported.
• String or UUID changes made by this patch: None

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9103734 [details]
Bug 1583957 - Indicate support for autocomplete=(username|new-password|current-password). r=farre

While this doesn't sound pressing the fix looks trivial and we are still early in the 68esr cycle, so let's uplift and make password autocomplete work as intended.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/e728a9895589