1583984 - [wpt-sync] Sync PR 19308 - Fix for AllowPaymentRequest Bug(972089)

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19308
Details from upstream follow.

Charlie Hu <[e-mail]> wrote:

Fix for AllowPaymentRequest Bug(972089)

The solution is to snapshot the value of frame policy at the beginning of
a local_frame_client navigation and use it during document initialization.
If the frame owner is a remote one, the old value is used.

• capture frame policy at the start of navigation

  • local_frame_client_impl
  • NavigationInfo
  • render_frame_impl.BeginNavigationInternal

• pass it from renderer process to browser process through
  CommonNavigationParams in navigation_params.mojom

  • MakeCommonNavigationParams

• use value in CommonNavigationParams to init navigation_params

  • render_frame_impl.CommitNavigationInternal
  • web_navigation_params
    -> DocumentInit
    -> Document::InitializeFeaturePolicy

More detailed information could be found on crbug page.

Bug: 972089
Change-Id: I694aa46b6e8e04bebc86b0e7886b856a9a302905

Reviewed-on: https://chromium-review.googlesource.com/1796119
WPT-Export-Revision: 2e711f96aac182e9796ba1471c69fd8b520acd8f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1931847f146d2f4cb86d161ecc39cfe0516d4aaa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=23bf0b73fe017851c7f2a03de027f209cd5ffeb1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=021378e232ee13f57cab2abe31e115e2f43b44ab

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaea561dc7c0f2077dca1eac9e9d015656b3ac2d

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=aed66a32bcfafd3b62a3f5775f1c243159c64996

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a713c15ccb94d9d8804fe04361c7cc749e7f990

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=caa5830dbc35e9a6c636c826837256796b0fe08c

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=870cc196d491e504bbaa81860e6af015d9a4d084

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b91dba7bf1c2ba94b3bfbe09eeccdc6502281b4b

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9caaff8fb8ef2cea0a28c0cda80229e9e260a6d4

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4cf45792e7d1fabe1379147e9d3c609ac159ef5

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b9d691b48fd204fb5aa51e0110704303197f5b2

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=250b8cfa3ab33e11621ac20da4e3ae5626244622

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=09253c3f757763394dd8ee1cd853b2bcb5518027

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d788f93d41e759dc3e74f6a44b0cc2fdf852c4

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e59dfe224939fd91bda1a92e5529420a4f047e43

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 4 subtests

Firefox

OK : 1
PASS: 2
FAIL: 2

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 3
FAIL: 1

Firefox-only failures

/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https.html
Accessing navigator.serviceWorker in sandboxed iframe should throw.: Firefox: FAIL

Gecko CI Results

Ran 1 tests and 4 subtests
OK : 1
PASS : 2
FAIL : 2

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03831919b661
[wpt PR 19308] - Capture frame policy at the beginning of navigation, a=testonly

Comment 19

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/03831919b661