Closed Bug 1583984 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 19308 - Fix for AllowPaymentRequest Bug(972089)

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19308 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19308
Details from upstream follow.

Charlie Hu <chenleihu@google.com> wrote:

Fix for AllowPaymentRequest Bug(972089)

The solution is to snapshot the value of frame policy at the beginning of
a local_frame_client navigation and use it during document initialization.
If the frame owner is a remote one, the old value is used.

  • capture frame policy at the start of navigation

    • local_frame_client_impl
    • NavigationInfo
    • render_frame_impl.BeginNavigationInternal

  • pass it from renderer process to browser process through
    CommonNavigationParams in navigation_params.mojom

    • MakeCommonNavigationParams

  • use value in CommonNavigationParams to init navigation_params

    • render_frame_impl.CommitNavigationInternal
    • web_navigation_params
      -> DocumentInit
      -> Document::InitializeFeaturePolicy

More detailed information could be found on crbug page.

Bug: 972089
Change-Id: I694aa46b6e8e04bebc86b0e7886b856a9a302905

Reviewed-on: https://chromium-review.googlesource.com/1796119
WPT-Export-Revision: 2e711f96aac182e9796ba1471c69fd8b520acd8f

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 4 subtests

Firefox

OK : 1
PASS: 2
FAIL: 2

Chrome

OK : 1
PASS: 3
FAIL: 1

Safari

OK : 1
PASS: 3
FAIL: 1

Firefox-only failures

/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https.html
Accessing navigator.serviceWorker in sandboxed iframe should throw.: Firefox: FAIL

Gecko CI Results

Ran 1 tests and 4 subtests
OK : 1
PASS : 2
FAIL : 2

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03831919b661
[wpt PR 19308] - Capture frame policy at the beginning of navigation, a=testonly

https://hg.mozilla.org/mozilla-central/rev/03831919b661

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.