[wpt-sync] Sync PR 19309 - Do not simplify calculation across math functions
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19309 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19309
Details from upstream follow.
Xiaocheng Hu <xiaochengh@chromium.org> wrote:
Do not simplify calculation across math functions
The existing code is too aggressive in simplifying calc() expressions
that, math functions (min/max etc) can be simplified away when they
can be directly resolved. This doesn't match the spec (*), and is fixed
in this patch.(*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation
Bug: 825895
Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de
Reviewed-on: https://chromium-review.googlesource.com/1825325
WPT-Export-Revision: 9608f2654baa344f127dd8253ef050d6f3dd20b4
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5e35c2792a46b8023d8900eddd1215726959324
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9cb9a04052f59f5bf9961d2306fe78c4d3efcb4
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bde3b369b81d58bd6ffd17cd22bc9e86550567c6
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c44ddaf29a0a923221aef47df14e4f574d8bed
|
|
Assignee | |
Comment 5•5 years ago
|
||
Ran 1 tests and 10 subtests
OK : 1
FAIL : 10
New tests that have failures or other problems:
/css/css-values/minmax-angle-serialize.html
e.style['transform'] = "rotate(calc(max(1deg) + max(2deg)))" should set the property value: FAIL
e.style['transform'] = "rotate(calc(min(1deg) + min(2deg)))" should set the property value: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5b09da541f [wpt PR 19309] - Do not simplify calculation across math functions, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/99b2e3d332f5 [wpt PR 19309] - Update wpt metadata, a=testonly
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5b5b09da541f
https://hg.mozilla.org/mozilla-central/rev/99b2e3d332f5
Description
•