Open Bug 1583989 Opened 2 months ago Updated 2 months ago

Adding new tests to graphs view plots data points in white in certain scenarios

Categories

(Tree Management :: Perfherder, defect, P3)

defect

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: sclements, Assigned: sclements)

Details

Attachments

(1 file)

:alexandru-io reported this in a pr that was unrelated: https://github.com/mozilla/treeherder/pull/5379#issuecomment-534934924

It seems to only happen in very specific scenarios - I was able to reproduce some times but not others.

I'm having a hard time reproducing this bug consistently (following the steps in your video). I've tried dozens of times and only seen it once or twice, which means it's going to be a pain to pinpoint the problem. How often have you experienced this alexandru? Also please post the video in this bug.

Flags: needinfo?(alexandru.ionescu)
Attached file Recording
Flags: needinfo?(alexandru.ionescu)

Pretty rare. Not sure how the colors are selected in the code, but probably getting white out of the color list if accessible would be a good idea.
I'm curious, will take a look at the code and try to figure out if this is possible.

White is not one of the specified colors :) It must be a default value being set at the graph library level due to an absence of an assigned color. I think the issue might have to do with how the colors are being assigned in the createGraphObject because the legend border color for the test this happens to is grey, yet the checkbox was checked. It should only be grey if the checkbox is not checked (this is the default for tests with a visibility=false). If you see this happen again, refreshing the page should be a temporary solution.

(In reply to Alexandru Ionescu :alexandrui from comment #3)

Pretty rare. Not sure how the colors are selected in the code, but probably getting white out of the color list if accessible would be a good idea.
I'm curious, will take a look at the code and try to figure out if this is possible.

Thanks - I appreciate the initiative! If you don't have time or get stuck, let me know and I'll look into it. If you do want to work on it, you can reassign it to yourself.

Priority: P1 → P3
You need to log in before you can comment on or make changes to this bug.