Closed Bug 1583993 Opened 4 years ago Closed 4 years ago

Expanded megabar stays open after switching out of the Firefox window

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Iteration:
71.2 - Sept 16 - 29
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

expanded+unfocused megarbar
40.88 KB, image/png
Details
Bug 1583993 - Check the focused attribute in startLayoutExtend and endLayoutExtend. r?dao
47 bytes, text/x-phabricator-request
Details | Review

This worked when bug 1579004 landed and appears to have broken in the time since. Dao, do you know what might have caused this?

Flags: needinfo?(dao+bmo)
Priority: -- → P1

This is the focused property reflecting document.activeElement == inputField even in unfocused windows. If we don't want this for the megabar, we need to check the focused attribute. I'm not sure that we want to change this, as it seems like unnecessary movement when unfocusing and refocusing a window. The current behavior seems fine to me. I guess there's an argument to be made for making it easier to drag unfocused windows or something? Then again the same tradeoff exists for the focused window.

Flags: needinfo?(dao+bmo)

I would say this should be fixed. Not fixing this introduces a new state to the Megabar, which is Expanded & Unfocused. This isn't part of the spec and also doesn't look good, at least on Mac – the bar lacks its border which gives it an unpolished look. At the very least a border should be added in this state.

I would say the movement seen when re-focusing the window is consistent with the Megabar design. When the user re-focuses the window, the Urlbar jumps out at them and is very prominent, which afaik is what we're going for with Megabar.

I agree with Harry, mostly the expanded megabar looks exotic, and that's fine when you connect it to a state like focused. with no state connection it makes Firefox look "broken".

Iteration: --- → 71.2 - Sept 16 - 29
Points: --- → 1
Regressed by: 1583495
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Blocks: 1583708
Attachment #9095529 - Attachment description: Bug 1583993 - Check both document.activeElement and the focused attribute in UrlbarInput::focused. r?dao → Bug 1583993 - Check the focused attribute in startLayoutExtend and endLayoutExtend. r?dao
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/baef9e166b23
Check the focused attribute in startLayoutExtend and endLayoutExtend. r=dao

https://hg.mozilla.org/mozilla-central/rev/baef9e166b23

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Flags: qe-verify+
Flags: needinfo?(cristian.comorasu)
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(cristian.comorasu)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.