Closed Bug 1584095 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19316 - Add serialization WPT for CSS comparison functions min/max on <angle>

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19316 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19316
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Add serialization WPT for CSS comparison functions min/max on <angle>

Note that the test failures are due to an existing bug crbug.com/1008146
that we fail to sort terms in a summation in the serialization. The bug
is orthogonal to the implementation of min/max.

Bug: 978682
Change-Id: Ieb04637427bdd7ba30e3bed82036d098598b6bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824835
Commit-Queue: Xiaocheng Hu \<xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700135}

PR 19316 applied with additional changes from upstream: 66689b5c50fa635f64ef48cff2498b7d17937dae
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 22 subtests
OK     : 1
FAIL   : 22

New tests that have failures or other problems:
/css/css-values/minmax-angle-serialize.html
    e.style['transform'] = "rotate(calc(1rad + max(1deg)))" should set the property value: FAIL
    e.style['transform'] = "rotate(calc(1rad + min(1deg)))" should set the property value: FAIL
    e.style['transform'] = "rotate(calc(max(1deg) + 1rad))" should set the property value: FAIL
    e.style['transform'] = "rotate(calc(max(1deg) + max(2deg)))" should set the property value: FAIL
    e.style['transform'] = "rotate(calc(min(1deg) + 1rad))" should set the property value: FAIL
    e.style['transform'] = "rotate(calc(min(1deg) + min(2deg)))" should set the property value: FAIL
    e.style['transform'] = "rotate(max(0.25turn, 1.57rad, 90deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(max(1deg, 2deg, 3deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(max(3deg, 2deg, 1deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(max(90deg, 1.57rad, 0.25turn))" should set the property value: FAIL
    e.style['transform'] = "rotate(min(0.25turn, 1.57rad, 90deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(min(1deg, 2deg, 3deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(min(3deg, 2deg, 1deg))" should set the property value: FAIL
    e.style['transform'] = "rotate(min(90deg, 1.57rad, 0.25turn))" should set the property value: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b06e41e0d7
[wpt PR 19316] - Add serialization WPT for CSS comparison functions min/max on <angle>, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b2b06e41e0d7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.