1584140 - Lower labels from Graphs view are being cut off

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P3)

Description

[Ionuț Goldan [:igoldan]]

Attachment: lower-legend-can-get-cutoff.png

I noticed there are often cases when date labels from the bottom are cut off.

Comment 1

[Ionuț Goldan [:igoldan]]

The Graphs view I've used was from https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=mozilla-central,1834678,1,10&series=mozilla-central,1955233,1,10&series=mozilla-central,2110541,1,10&series=mozilla-central,2117747,1,10&series=mozilla-central,1834673,1,10&series=mozilla-central,1955223,1,10&series=mozilla-central,2110530,1,10&series=mozilla-central,2117883,1,10&series=mozilla-central,1834668,1,10&series=mozilla-central,2008512,1,10&series=mozilla-central,2110577,1,10&series=mozilla-central,2117729,1,10&highlightAlerts=1&zoom=1567762360210,1569062408000,16.62560553633218,18.17439446366782

Comment 2

[Sarah Clements [:sclements]]

The solution might be to set the right chartPadding or the tickFormat for the x axis. It might need to be determined dynamically similar to what I did for the y axis with setLeftPadding, which generates a width based on the character length of the largest label text.

Comment 3

[Mellina Yonashiro]

Hi Sarah,

I'm an Outreachy applicant. May I try to solve this bug?

I will send you a message soon to introduce myself.

Thanks!

Comment 4

[Sarah Clements [:sclements]]

Hi Mellina - yes, I'll assign it to you.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5427