1584169 - Welcome to Firefox card is not visible when rotating the device

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Eliza Balazs]

Environment:
Device: Pixel 3 XL (Android 9); Prestigio Grace X5 (Android 4.4.2)
Build: Nightly 71.0a1 (2019-09-25);

Steps to reproduce:

1. Install Firefox and launch it;
2. Go to Bookmarks panel;
3. Go to Top Sites panel;
4. Rotate the device in landscape mode and back to portrait mode;
5. Observe the "Welcome to Firefox" card;

Expected result:
The "Welcome to Firefox" card is displayed.

Actual result:
The "Welcome to Firefox" card is not entirely visible in landscape and portrait mode after rotating the device.

Notes:

• Not reproducible on tablet;
• The issue is also reproducible when scrolling the Top Sites page;
• Video: https://drive.google.com/file/d/1gTp_aRFrxoLnznsZBSUiiH4tQ-yxXBvK/view

Comment 1

[Chris Peterson [:cpeterson]]

Vlad, after rotating the device, can you scroll the "Welcome to Firefox" card back into view? Is this a bug in the scroll position we return to after rotating the device?

Do you think this bug should be a release blocker?

Comment 2

[Chris Peterson [:cpeterson]]

Eliza says the "Welcome to Firefox" the card can be scrolled back into view. So this sounds like it might just be a bug in the remembered scroll position?

Comment 3

[Petru-Mugurel Lingurar [:petru]]

This is indeed a very interesting issue, one which I think might actually be a feature of the RecyclerView we are using to display the list.
(There are multiple questions on the Internet about how to disable this kind of autoscroll behavior when refreshing data)

How this bug manifests:

• Have the TopSites view (the 8 topsites grid) just partially shown
• Navigate to a webpage / another section of the awesomescreen (like bookmarks / history)
• When returning to the TOP SITES section of the awesomescreen the TopSites view (the 8 topsites grid) will be fully visible (althoug previously there was just a small part of that view shown, with the other being outside of the screen)
• Users are free to scroll the page as they desire, they can scroll up to see the card again.

One important thing to note is that this is not a new regression, but a behavior that can be observed on the recent release also - https://drive.google.com/file/d/1VQicz02MV6oBijS-gHlUEojB-OnS7aeE/view?usp=sharing

I will continue to investigate this issue but I don't think it should affect the SignIn feature.
Chris, Eliza, do you agree?

Comment 4

[Eliza Balazs]

Indeed, this seems to be an older issue, although the "Welcome to Firefox" card makes it more visible.
From my point of view its important the card to be fully visible for this feature, even if the page can be scrolled.
Thanks!

Comment 5

[Vlad Baicu]

On portrait you have to scroll all the way to the bottom and upon returning the RV will scroll a bit up to have the topsites fully visible. On landscape however it's entirely different because if let's say I have the Sign up row fully visible, upon returning from another tab the RV will scroll down and on some devices sign up row might not be visible at all.

Based on these conditions, this bug is an UI inconvenience.

@Eliza, since this is an older issue, maybe we can find a regression window? Both me and Petru have debugged this rather intensively the past 2 days and we still haven't been able to track down the source of this scrolling behaviour.

Comment 6

[Vlad Baicu]

@Chris - In my opinion I don't think this is a release blocker as the scenarios to reproduce seem rather uncommon and only affect the visiblity of the sign up row in landscape mode (and even that depends on the display of the device you are running the app on - on smaller resolutions, a higher portion if not all of the sign up row might will not be visible). Ideally, we want to fix this with time to spare, so let's currently focus on that

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Vlad Baicu from comment #6)

@Chris - In my opinion I don't think this is a release blocker as the scenarios to reproduce seem rather uncommon and only affect the visiblity of the sign up row in landscape mode (and even that depends on the display of the device you are running the app on - on smaller resolutions, a higher portion if not all of the sign up row might will not be visible). Ideally, we want to fix this with time to spare, so let's currently focus on that

Since this is not a new regression and the user can still scroll up to see the top content, I agree with your recommendation that this bug is not a release blocker for the Fennec Sign-in buttons.

In fact, I suggest that we don't bother fixing this bug. Like you said, this an uncommon case and we have more critical P1 Fennec bugs. I will reset this bug's priority so the Fennec triage meeting can decide whether QA should look for the regression window or we can close this bug as WONTFIX.

Comment 8

[Laurentiu Apahidean]

I performed a regression test and narrowed the regression window from [2018-07-16, 2018-07-18] (2 days) to [2018-07-16, 2018-07-17] (1 days) and generated the changeset link: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ed1506d1dc7db3d70a3feed95f1456bce05bbee&tochange=8dab948a10f073a46f13f55f94d1f6514c7360ac

Comment 9

[Chris Peterson [:cpeterson]]

Thanks, Laurentiu!

There are a lot of Android changes in that regression window, but one that looks suspicious to me is bug 1385464: Update Android support library from version 23.4 to 26.1.

Comment 10

[athomas]

Quick clarification on the behaviour here

The "Welcome to Firefox" card is not entirely visible in landscape and portrait mode after rotating the device.

Based on the video, it looks like the user is just scrolled down on the page. Can they scroll back up to see the full "Welcome to Firefox" card?

Comment 11

[Eliza Balazs]

(In reply to athomas from comment #10)

Based on the video, it looks like the user is just scrolled down on the page. Can they scroll back up to see the full "Welcome to Firefox" card?

Hi!
Yes, the page can be scrolled back up to see the full "Welcome to Firefox" card.

Comment 12

[Chris Peterson [:cpeterson]]

P2. We decided to not fix this bug for Fennec ESR 68.2. We can consider this bug for later Fennec releases, but it is a minor issue. We should consider just WONTFIX'ing this bug.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

:vlad.baicu, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 15

[Vlad Baicu]

Unfortunately, I haven't been able to find the bug that caused the regression yet - that's quite the regression window. Will do once I find it.

Comment 16

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.