1584176 - The “x” button from the Breach warning doesn't have a hover effect in Dark Mode

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: BreachDialog_hover.mp4

[Affected versions]:

• Firefox Beta 70.0b9 (Build ID: 20190923154733) (64-bit)
• Nightly 71.0a1 (Build ID: 20190925215653) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 16.04 x64.

[Prerequisites]:

• Have a Firefox profile with at least one breached account.
• The dark mode is active.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to “about:logins” page and select a breached login
3. Hover the “x” button from the Breach warning.
4. Observe the behavior.

[Expected result]:

• The “x” button has a hover effect.

[Actual result]:

• The “x” button has not a hover effect.

[Notes]:

• The issue is not reproducible using white mode.
• Attached a screen recording with the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1584176 - Use a fixed background color for the :hover and :hover:active of the dismiss button since the background-color of the breach alert is fixed. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb8b13c8ef34
Use a fixed background color for the :hover and :hover:active of the dismiss button since the background-color of the breach alert is fixed. r=MattN

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bb8b13c8ef34

Comment 5

[Maria Heres, inactive, contact Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191010214019) on Windows 10 x64, Mac 10.15, Ubuntu 16 x64.

• The “x” button has a hover effect now.