1584215 - Crash in mozilla::MozPromise<T>::ThenValueBase::Disconnect

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Viktor Jägersküpper]

I submitted the crash report 25653c2e-ed08-4f92-ac66-cc1ca0190926, and there are already a few similar reports. It seems that the latest Nightly (20190926094200) triggers it, but the crash has occured with another build a few months ago.

I am not sure if the component for this bug is correct, I just guessed it from the source file.

Comment 1

[Marcia Knous [:marcia]]

Looks as if crashes started in 20190926094200 and are Windows only so far. Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c31591e0b66f277398bee74da03c49e8f8a0ede0&tochange=1dc1a755079a15e35cb234db511e52ab463b2f42.

Looks as if Bug 1578615 touched code in this area. Moving to a better home, hopefully and adding a ni.

Comment 2

[Viktor Jägersküpper]

Looks as if crashes started in 20190926094200 and are Windows only so far.

Actually I am using Linux, but all the other reporters are using Windows 10 if I understand the statistics correctly.

Comment 3

[Viktor Jägersküpper]

Steps to reproduce with a new profile:

1. Set "media.autoplay.default" to "0"
2. Go to www.tagesschau.de (german news site, no ads)
3. Look for a link which leads to a page with an embedded video (those are indicated by a camera icon on the picture) and open the link via right-click and "open in a new tab" so that the new tab loads in background
4. Switch to the new tab
   (5. Scroll down until the embedded video appears)
   -> crash

The mentioned site is quite popular so you will probably get many crash reports (more than 100 as of writing).

Comment 4

[Alastor Wu [:alwu]]

I have already had a patch for it, but now the phabricator has a issue, which makes my patch being a draft state forever. Once it gets fixed, I willl land my code ASAP.

Comment 5

[Marcia Knous [:marcia]]

Adding the macOS specific signature.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1584215 - complete the request once promise is resolved.

The request is used to track if the promise is resolved or not, so we should call its Complete() method once promise is resolved, in order to keep the state of the request correct.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c41959333fb
complete the request once promise is resolved. r=chunmin

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8c41959333fb

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Reproduced the issue with Firefox 71.0a1 (20190926213542) on Windows 10x64.
The issue is verified fixed with Firefox 71.0b9 (20191007215350) on Windows 10x64, Ubuntu 18.04 and macOS 10.12. No tab crash encountered after following the STR from comment 3.

Comment 10

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.