1584218 - ui.popup.disable_autohide has no effect on HTML:datalist popups

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[alexander :surkov (:asurkov)]

setting ui.popup.disable_autohide to true, opening a datalist popup for

data:text/html,<input list="datalist"><datalist id="datalist"><option>a</option><option>bobo</option></datalist>

and switching a window closes the popup

It turns out that this check is not enough https://searchfox.org/mozilla-central/source/layout/xul/nsXULPopupManager.cpp#201 to handle this case.

Emilio, it might be a quick to fix thing, but very helpful. Do you have ideas what a fix could be?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

That's handled in nsFormFillController. The blur case is this one: https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/toolkit/components/satchel/nsFormFillController.cpp#866

Which ends up calling ClosePopup(). Probably just a pref check there would do?

Comment 2

[Brian Grinstead [:bgrins]]

Somewhat related issue I've seen: the <select> popup is also hard to inspect/debug for this reason (closes when trying to inspect in the Browser Toolbox). I believe this should be fixed on the frontend with a pref check before calling hidePopup() at https://searchfox.org/mozilla-central/rev/f1e99da78fe6c3c68696358dac06aed90f8112d3/toolkit/actors/SelectParent.jsm#248.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Probably you just want the blur one right? Otherwise you cannot hide it at all.

https://searchfox.org/mozilla-central/rev/f1e99da78fe6c3c68696358dac06aed90f8112d3/toolkit/actors/SelectChild.jsm#310 is probably the place then.

Comment 4

[alexander :surkov (:asurkov)]

yeah, closePopup looks too harsh, perhaps blur is the better place

Comment 5

[alexander :surkov (:asurkov)]

I filed a patch https://phabricator.services.mozilla.com/D47322, it's not linked with the bug for some reason. Emilio, if you didn't receive emails (who knows), I asked you for review there.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: Bug 1584218 - form autofill and HTML:select don't respect ui.popup.disable_autohide preference

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66ded616f2a1
form autofill and HTML:select don't respect ui.popup.disable_autohide preference r=emilio,MattN

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/66ded616f2a1