1584281 - Update megabar box-shadow and add the same box-shadow to the legacy (non-megabar) results panel

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak]]

In the one-off redesign mail-thread Verdi said "I think we should add a shadow to bottom of the panel", so I'm filing this placeholder bug to better define what he wants.

=> Verdi, please give us some specs.

Comment 1

[Harry Twyford]

Attachment: megabar_shadow

We added a shadow in bug 1575360. I've attached a screenshot of what it looks like. Verdi, are we looking for a different shadow here?

Comment 2

[Dão Gottwald [:dao]]

I think verdi was referring to the old design.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking this spooky Halloween search box issue for 70. We could still take a shadow patch for beta 12 or 13. Past that, wontfix and then 70 will be released sadly shadowless. (Following up in email with mverdi)

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1584281 - Update megabar box-shadow and add the same box-shadow to the legacy (non-megabar) results panel. r=mak

Comment 5

[Verdi [:verdi] Best to slack me]

(In reply to Marco Bonardo [::mak] from comment #0)

=> Verdi, please give us some specs.

box-shadow: 0 5px 18px 0 rgba(0, 0, 0, .2);

(In reply to Harry Twyford [:harry] from comment #1)

We added a shadow in bug 1575360. I've attached a screenshot of what it looks like. Verdi, are we looking for a different shadow here?

(In reply to Dão Gottwald [::dao] from comment #2)

I think verdi was referring to the old design.

In the meeting I was referring to the old design but I think we should use this value for the new design also.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb6b5785edf
Update megabar box-shadow and add the same box-shadow to the legacy (non-megabar) results panel. r=mak

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3cb6b5785edf

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1584281 - Add box-shadow to the legacy (non-megabar) results panel (beta-only patch). r=mak

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9098794 [details]
Bug 1584281 - Add box-shadow to the legacy (non-megabar) results panel (beta-only patch). r=mak

Beta/Release Uplift Approval Request

• User impact if declined: Polish issue
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch
• String changes made/needed:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9098794 [details]
Bug 1584281 - Add box-shadow to the legacy (non-megabar) results panel (beta-only patch). r=mak

CSS tweak for search bar. OK for uplift for beta 13.

Comment 11

[Narcis Beleuzu [:NarcisB]]

There are conflicts while trying to graft the patch.
" warning: conflicts while merging browser/themes/shared/urlbar-searchbar.inc.css! "

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c7c496cb0c58

Comment 13

[ovidiu boca[:Ovidiu]]

(In reply to Dão Gottwald [::dao] from comment #9)

Comment on attachment 9098794 [details]
Bug 1584281 - Add box-shadow to the legacy (non-megabar) results panel (beta-only patch). r=mak

• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

Hi, Dão can you please add the exact steps or what is the action that needs to be done to be able to verify this fix? Thanks

Comment 14

[Dão Gottwald [:dao]]

Steps: Type in the address bar, see if the results panel has a drop shadow.

Comment 15

[ovidiu boca[:Ovidiu]]

Attachment: This is the drop shadow from the results panel?.png

Thanks, I followed the steps and just to be sure that we are on the same page please see the attached doc and let me know if this is the expected. I'm using a Mac OS X 10.14 with FF Nightly 71.0a1(2019-10-07).

Comment 16

[Dão Gottwald [:dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #15)

Created attachment 9099490 [details]
This is the drop shadow from the results panel?.png

Thanks, I followed the steps and just to be sure that we are on the same page please see the attached doc and let me know if this is the expected. I'm using a Mac OS X 10.14 with FF Nightly 71.0a1(2019-10-07).

No, that's the focus ring. Apparently the megabar drop shadow is broken on Mac, filed bug 1587027 on this.

Comment 17

[ovidiu boca[:Ovidiu]]

I see, so this should be verified on Windows and Linux OSes? If yes please attach a spec or a print screen with the expected result. Thanks

Comment 18

[Dão Gottwald [:dao]]

You don't need to bother verifying in Nightly. On beta we're going from no shadow at all to having a shadow, so just make sure you see that. It's the same shadow you should see in Nightly on Windows and Linux, if you need a reference.

Comment 19

[ovidiu boca[:Ovidiu]]

Attachment: shadow.jpg

I tested it on Windows 10 and Ubuntu 18.04 with FF beta 70.b13 and FF Nightly 71.0a1(2019-10-08) and I see this result, please see the attached print screen. Dao, please confirm if this is the expected result for this fix?

Comment 20

[Dão Gottwald [:dao]]

Looks good, thanks.