1584288 - Broken error message when incorrect bug # provided

Status: RESOLVED DUPLICATE of bug 1563606

(Conduit :: Phabricator, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

I got a broken error message when trying to land a commit with a broken bug # on it. Specifically, I tried to push patches for a bug which I did not have access to.

The error message I got looked like this:

(debug) Response: {"result": null, "error_code": "ArgumentCountError", "error_info": "Too few arguments to function PhutilErrorHandler::handleError(), 4 passed in /app/phabricator/externals/extensions/sentry/sentry/src/ErrorHandler.php on line 361 and exactly 5 expected"}

I believe that the problem is that an error handler registered by libphutil expects 5 arguments, and the sentry-php handler passes down only 4.

• libphutil: https://github.com/phacility/libphutil/blob/f39a03df2bc52777f7e5572baa9bb8df2a9b016c/src/error/PhutilErrorHandler.php#L183
• sentry-php: https://github.com/getsentry/sentry-php/blob/5896f9f0a00a7525797764ba42091dfbde22a746/src/ErrorHandler.php#L386

Comment 1

[Māris Fogels [:mars] (please needinfo)]

Thanks for the clear steps to reproduce. I've added it to the original bug. Should definitely help us fix this.