Closed Bug 1584290 Opened 6 months ago Closed 6 months ago

Review reftest tests skipped on Android

Categories

(Testing :: General, task, P1)

Version 3
task

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

Some reftest tests currently skipped on Android were skipped because they failed in the android test environment of the time: the android 4.3 emulator, or perhaps a pandaboard or tegraboard. Today's emulator is much faster and has other improved capabilities. Also, our code has evolved. This seems like a good time to review skipped tests: Can some of them be enabled without introducing new failures?

I am reviewing skip-if and random-if annotations for Android and excluding annotations with explanatory comments that appear to be recent or relevant, as well as annotations specifically targeting geckoview, e10s, or webrender.

I think it would be interesting to challenge fuzzy-if annotations also, but that's a big job...maybe in another bug.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=68cb82ff18e483c1a2d9d64400d3d3dca27a457c

According to before/after test counts, this change enables about 536 tests.

Depends on: 1584652

Most of these tests have been disabled for a long time; they run well
in the current test environment.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b9569b9b9e3
Enable many reftests on Android; r=geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.