1584290 - Review reftest tests skipped on Android

Status: RESOLVED FIXED

(Testing :: General, task, P1)

Description

[Geoff Brown [:gbrown]]

Some reftest tests currently skipped on Android were skipped because they failed in the android test environment of the time: the android 4.3 emulator, or perhaps a pandaboard or tegraboard. Today's emulator is much faster and has other improved capabilities. Also, our code has evolved. This seems like a good time to review skipped tests: Can some of them be enabled without introducing new failures?

Comment 1

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=5a9ee5b04a166f5cfd4cf31d3d1fd3f9845d0372

Comment 2

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=d80502298ff69cb7238ccc7b823c623f2438404f

Comment 3

[Geoff Brown [:gbrown]]

I am reviewing skip-if and random-if annotations for Android and excluding annotations with explanatory comments that appear to be recent or relevant, as well as annotations specifically targeting geckoview, e10s, or webrender.

I think it would be interesting to challenge fuzzy-if annotations also, but that's a big job...maybe in another bug.

Comment 4

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=68cb82ff18e483c1a2d9d64400d3d3dca27a457c

According to before/after test counts, this change enables about 536 tests.

Comment 5

[Geoff Brown [:gbrown]]

Attachment: Bug 1584290 - Enable many reftests on Android; r=

Most of these tests have been disabled for a long time; they run well
in the current test environment.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b9569b9b9e3
Enable many reftests on Android; r=geckoview-reviewers,snorp

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5b9569b9b9e3