Closed Bug 1584292 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19330 - [Native File System] Aborting a directory iteration succeeds

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19330 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19330
Details from upstream follow.

Olivier Yiptong <oyiptong@chromium.org> wrote:

[Native File System] Aborting a directory iteration succeeds

The return statement of the async iterator was not returning the
expected type. This removes the ability to cancel an iteration
which fixes the bug where an error would be thrown otherwise.

A full implementation of directory iteration will re-implement
this functionality correctly.

BUG=1007509

Change-Id: I77f3b76b117b7df939e73da826f4fc9b82e9441e
Reviewed-on: https://chromium-review.googlesource.com/1826993
WPT-Export-Revision: 385c049722edd8485f8a4a6cca5366e0a0148f52

PR 19330 applied with additional changes from upstream: e7b232f535cf1ebd0026bd66d1ff3bf096744862
Ran 3 tests and 8 subtests
OK     : 3
FAIL   : 8

New tests that have failures or other problems:
/native-file-system/native_FileSystemDirectoryHandle-getEntries.tentative.https.manual.window.html
    User granted write access.: FAIL
    User succesfully selected an empty directory.: FAIL
    getEntries(): full iteration works: FAIL
    getEntries(): returning early from an iteration works: FAIL
/native-file-system/sandboxed_FileSystemDirectoryHandle-getEntries.tentative.https.any.html
    getEntries(): full iteration works: FAIL
    getEntries(): returning early from an iteration works: FAIL
/native-file-system/sandboxed_FileSystemDirectoryHandle-getEntries.tentative.https.any.worker.html
    getEntries(): full iteration works: FAIL
    getEntries(): returning early from an iteration works: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/360a94b12f3b
[wpt PR 19330] - [Native File System] Aborting a directory iteration succeeds, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/eba0611ad299
[wpt PR 19330] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/360a94b12f3b
https://hg.mozilla.org/mozilla-central/rev/eba0611ad299

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.