1584318 - Implement RTCRtcpParameters.cname/reducedSize

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

Right now we generate a single UUID per RTCPeerConnection, and use it on all send tracks, and do not expose its value to JS. This causes a lot of wpt to fail.

Comment 1

[Byron Campen [:bwc]]

https://wpt.live/webrtc/RTCRtpParameters-rtcp.html

Comment 2

[Byron Campen [:bwc]]

Bugs 1765851 and 2019359 are additional properties on RTCRtpParameters. Bug 2019370 will probably need to be fixed to get all of the RTCRtcpParameters.cname tests passing, even if we fix this bug.

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1584318: Implement RTCRtcpParameters.cname/reducedSize. r?ng

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99641e2fe13d
https://hg.mozilla.org/integration/autoland/rev/fe7989365b2e
Implement RTCRtcpParameters.cname/reducedSize. r=ng

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fe7989365b2e

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/fe7989365b2e

Comment 9

[Hamish Willee]

FF154 MDN work for this can be tracked in https://github.com/mdn/content/issues/44834

Can you confirm that this has has actually shipped and that it gets/sets rtcp property in the object set/returned from all of: RTCRtpReceiver.getParameters(), RTCRtpSender.getParameters() and RTCRtpSender.setParameters(). [I ask because subject says "implemented" and that doesn't always mean "shipped"].

Comment 10

[Byron Campen [:bwc]]

Yes, all of those are shipped.