1584335 - [wpt-sync] Sync PR 19341 - Add serialization WPT for CSS comparison functions min/max on <length>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19341 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19341
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Add serialization WPT for CSS comparison functions min/max on <length>

Note that the test failures are due to an existing bug crbug.com/1008146
that we fail to sort terms in a summation in the serialization. The bug
is orthogonal to the implementation of min/max.

Bug: 978682
Change-Id: I8384274e4af3833003eee7e131fa8b46741f820b
Reviewed-on: https://chromium-review.googlesource.com/1827724
WPT-Export-Revision: 3b718bcea300caf026e1ade2eeca417252449b26

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=06d499dc684510cae82f75b5906d73d3e308fbdd

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5beb10b5ae11d7266124722abddebd6146ca9d3

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9be0ce004c15016261c054a8d23de84e77dc467b

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 1 tests and 44 subtests
OK     : 1
FAIL   : 44

New tests that have failures or other problems:
/css/css-values/minmax-length-serialize.html
    e.style['letter-spacing'] = "calc(10px + max(1em))" should set the property value: FAIL
    e.style['letter-spacing'] = "calc(10px + min(1em))" should set the property value: FAIL
    e.style['letter-spacing'] = "calc(max(1em) + 10px)" should set the property value: FAIL
    e.style['letter-spacing'] = "calc(max(1em) + min(10vw) + max(10px))" should set the property value: FAIL
    e.style['letter-spacing'] = "calc(min(10px) + max(1em) + min(10vw))" should set the property value: FAIL
    e.style['letter-spacing'] = "calc(min(1em) + 10px)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(10px, 20px, 30px)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(10vw, 1em, 20px)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1Q)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1ch)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1cm)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1em)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1ex)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1in)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1mm)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1pc)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1pt)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1px)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1rem)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1vh)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1vmax)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1vmin)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(1vw)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(20px, 1em, 10vw)" should set the property value: FAIL
    e.style['letter-spacing'] = "max(30px, 20px, 10px)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(10px, 20px, 30px)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(10vw, 1em, 20px)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1Q)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1ch)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1cm)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1em)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1ex)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1in)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1mm)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1pc)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1pt)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1px)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1rem)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1vh)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1vmax)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1vmin)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(1vw)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(20px, 1em, 10vw)" should set the property value: FAIL
    e.style['letter-spacing'] = "min(30px, 20px, 10px)" should set the property value: FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a906a091cf6
[wpt PR 19341] - Add serialization WPT for CSS comparison functions min/max on <length>, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e326b767433e
[wpt PR 19341] - Update wpt metadata, a=testonly

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1a906a091cf6
https://hg.mozilla.org/mozilla-central/rev/e326b767433e