158435 - Page Info's label-control association is broken (should be by id).

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Nicolás Lichtmaier]

According to the HTML spec, the "for" attribute in a label specifies the *id* of
a form control, not the name
(http://www.w3.org/TR/html401/interact/forms.html#h-17.9.1). Check how the
example in the spec uses both name and id attributes. But the code in
pageInfo.js associate it by the name attribute.

Comment 1

[Nicolás Lichtmaier]

Attachment: testcase

Comment 2

[Nicolás Lichtmaier]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 92081 [details] [diff] [review]
patch

sr=bzbarsky

Comment 4

[Nicolás Lichtmaier]

Attachment: silly and harmless thing fixed

Comment 5

[Nicolás Lichtmaier]

Attachment: Ops, attached the old file instea of the new one =/

Comment 6

[Daniel Brooks [:db48x]]

Comment on attachment 92083 [details] [diff] [review]
Ops, attached the old file instea of the new one =/

You are correct that the label really should match the id, and not the name.
However, because mozilla also associates the for attribute with the names, this
should also match with the names. The absolute easiest way to make this change
is to add "|| formfields[j].id == whatfor" to the test inside the inner loop.

I'd rather you didn't use .form anywhere, it has bugs, though I don't remeber
the bug numbers right off. A couple of the comments in the code mention it
though. I think .getAttribute("form") works correctly though, if you really
need to do that.

Comment 7

[Nicolás Lichtmaier]

>You are correct that the label really should match the id, and not the name.
>However, because mozilla also associates the for attribute with the names.

Where? If it does so, it's broken there.

>I'd rather you didn't use .form anywhere, it has bugs, though I don't remeber
>the bug numbers right off. A couple of the comments in the code mention it
>though. I think .getAttribute("form") works correctly though, if you really
>need to do that.

Uhm... control.form is very widely used in pages, it gets the form object from a
control. Being so idely used... why would be the bug that prevents its use here?
Anyway it's an optimization, and it coud be removed...

Comment 8

[Nicolás Lichtmaier]

AFAICS if I open the testcase and click on "Good label", the appropiate control
get focused. If I click on "Bad label" it doesn't. It seems that Mozilla is
getting right the label-form association and doesn't use name at all.

Comment 9

[Daniel Brooks [:db48x]]

which test case?

Comment 10

[Nicolás Lichtmaier]

er... the one attached to this bug, aptly named "testcase" =)

Comment 11

[Daniel Brooks [:db48x]]

oh, that one. hrm, what does it do when you delete the doctype (putting it into 
quirks mode?) (I don't have Mozilla on this computer here at work)

Comment 12

[Nicolás Lichtmaier]

I've tried with the page in quirks mode, same thing. Mozilla links the label to
the form only by the id attribute, ignoring the link by "name".

Comment 13

[Keyser Sose]

Comment on attachment 92083 [details] [diff] [review]
Ops, attached the old file instea of the new one =/

r=ksosez

Comment 14

[Brendan Eich [:brendan]]

Comment on attachment 92083 [details] [diff] [review]
Ops, attached the old file instea of the new one =/

Prevailing style clearly puts a space after if, for, and other keywords. 
Please follow it.

/be

Comment 15

[Nicolás Lichtmaier]

Attachment: Some spaces added

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 92120 [details] [diff] [review]
Some spaces added

Approval granted for trunk checkin.  Please request branch checkin once this is
verified on trunk with no regressions.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Approval for branch checkin; please change mozilla1.0.1+ to fixed1.0.1 when
checked in.

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on branch

Comment 20

[Patty Mac]

Verified on windows 2k, (netscape branch build: 2002-08-21-08-1.0)