Closed Bug 1584430 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19353 - [ScrollTimeline] Remove CompositingReason::kScrollTimelineTarget

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19353 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19353
Details from upstream follow.

Yi Gu <yigu@chromium.org> wrote:

[ScrollTimeline] Remove CompositingReason::kScrollTimelineTarget

Since we have supported main-thread AnimationWorklet, there is no need
to promote the scroll-source automatically for ScrollTimeline.

Changes to make:

  1. Attaching / detaching animation to ScrollTimeline no longer need to
    trigger compositing update nor paint property update.
  2. Animations with scroll timeline should fall back to main thread
    when the scroll source is not composited.
  3. ScrollTimeline::HasActiveScrollTimeline which used to help with
    making compositing decisions can be removed. However, an alternative
    should be implemented because it also optimized the compositing state
    change updates [1].

[1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc?g=0&l=307

Bug:1008720
Change-Id: I07dbefeb4e16e8be832b354f0a68bfd7cd0f6ee6
Reviewed-on: https://chromium-review.googlesource.com/1825720
WPT-Export-Revision: 6743a785db4e21069378f7dc31a31c443c498af6

Ran 2 tests
TIMEOUT: 2
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb30c80321ba
[wpt PR 19353] - [ScrollTimeline] Remove CompositingReason::kScrollTimelineTarget, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.