Closed Bug 1584445 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19357 - Implement abort for WebSocketStream handshake

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19357 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19357
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

Implement abort for WebSocketStream handshake

The WebSocketStream explainer describes being able to pass an
AbortSignal object to the WebSocketStream constructor to abort the
handshake. This wasn't implemented yet in Blink. Implement it.

Bug: 983030
Change-Id: I9d96bf145a4978867dd8ae98a13af9ad9cff752c
Reviewed-on: https://chromium-review.googlesource.com/1827116
WPT-Export-Revision: 8fa8ebdc5e9d715ef79ab0fffafcc7433e08327d

Ran 4 tests and 12 subtests
OK     : 4
FAIL   : 12

New tests that have failures or other problems:
/websockets/stream-tentative/abort.any.html
    abort after connect should do nothing: FAIL
    abort before constructing should prevent connection: FAIL
    abort during handshake should work: FAIL
/websockets/stream-tentative/abort.any.serviceworker.html
    abort after connect should do nothing: FAIL
    abort before constructing should prevent connection: FAIL
    abort during handshake should work: FAIL
/websockets/stream-tentative/abort.any.sharedworker.html
    abort after connect should do nothing: FAIL
    abort before constructing should prevent connection: FAIL
    abort during handshake should work: FAIL
/websockets/stream-tentative/abort.any.worker.html
    abort after connect should do nothing: FAIL
    abort before constructing should prevent connection: FAIL
    abort during handshake should work: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21a76bd16a43
[wpt PR 19357] - Implement abort for WebSocketStream handshake, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/1278f4cbcb6e
[wpt PR 19357] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/21a76bd16a43
https://hg.mozilla.org/mozilla-central/rev/1278f4cbcb6e

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.