1584457 - replace <textbox> in AccountWizard.xul

Status: RESOLVED FIXED

(MailNews Core :: XUL Replacements, task, P1)

Description

[Magnus Melin [:mkmelin]]

Replace <textbox> in AccountWizard.xul - https://searchfox.org/comm-central/rev/a8c6db8009b437b362eb2087adaf42b1e5477ef5/mailnews/base/prefs/content/AccountWizard.xul

We don't use most of this, but some, for nntp and movemail I guess.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1584457-textbox-html-input.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9096984 [details] [diff] [review]
1584457-textbox-html-input.patch

Review of attachment 9096984 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/AccountWizard.xul
@@ +80,4 @@
>                 accesskey="&fullnameLabel.accesskey;" control="fullName"/>
> +        <html:input id="fullName"
> +                    type="text"
> +                    mailtype="identity"

we can remove the mailtype. apparently not used

@@ +101,5 @@
> +          <hbox class="uri-element input-container" align="center" flex="1">
> +            <html:input id="email"
> +                        type="email"
> +                        wsm_persist="true"
> +                        mailtype="identity"

and here

@@ +261,5 @@
>                label="&incomingTitle.label;">
>      <vbox flex="1">
>        <description>&newsServerNameDesc.label;</description>
>        <separator class="thin"/>
>        <hbox align="center">

class="input-container" for this one?

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1584457-textbox-html-input.patch

Ah yes, I forgot that missing class.
Thanks.

Comment 4

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=852b022d09fff746f25b985bf430c8a466f4a13c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be89db948eee
replace <textbox> in AccountWizard.xul. r=mkmelin