Closed Bug 1584457 Opened 5 months ago Closed 5 months ago

replace <textbox> in AccountWizard.xul

Categories

(MailNews Core :: XUL Replacements, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: mkmelin, Assigned: aleca)

References

Details

Attachments

(1 file, 1 obsolete file)

Replace <textbox> in AccountWizard.xul - https://searchfox.org/comm-central/rev/a8c6db8009b437b362eb2087adaf42b1e5477ef5/mailnews/base/prefs/content/AccountWizard.xul

We don't use most of this, but some, for nntp and movemail I guess.

Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Attached patch 1584457-textbox-html-input.patch (obsolete) — Splinter Review
Attachment #9096984 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9096984 [details] [diff] [review]
1584457-textbox-html-input.patch

Review of attachment 9096984 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/AccountWizard.xul
@@ +80,4 @@
>                 accesskey="&fullnameLabel.accesskey;" control="fullName"/>
> +        <html:input id="fullName"
> +                    type="text"
> +                    mailtype="identity"

we can remove the mailtype. apparently not used

@@ +101,5 @@
> +          <hbox class="uri-element input-container" align="center" flex="1">
> +            <html:input id="email"
> +                        type="email"
> +                        wsm_persist="true"
> +                        mailtype="identity"

and here

@@ +261,5 @@
>                label="&incomingTitle.label;">
>      <vbox flex="1">
>        <description>&newsServerNameDesc.label;</description>
>        <separator class="thin"/>
>        <hbox align="center">

class="input-container" for this one?
Attachment #9096984 - Flags: review?(mkmelin+mozilla) → review+

Ah yes, I forgot that missing class.
Thanks.

Attachment #9096984 - Attachment is obsolete: true
Attachment #9097016 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/be89db948eee
replace <textbox> in AccountWizard.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.