Closed Bug 1584497 Opened 6 months ago Closed 6 months ago

Use emulator 29.2.1 for android wrench reftests

Categories

(Core :: Graphics: WebRender, task, P3)

Unspecified
Android
task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The previous emulator update (bug 1556058) left out wrench due to lots of test failures: https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=413981d4922a3ec494a95b783c1e84bdc128d0d0

This was due to bug 1555056. I filed the issue upstream and it is now fixed as of emulator 29.1.12 (although only when using the GPU backend, not when using swiftshader). Additionally, as of bug 1548339, we now use RGBA and swizzling rather than BGRA, so would no longer run in to this bug anyway.

I believe updating to the latest emulator, with the GPU backend, should fix the GL_INVALID_OPERATION error in glBlitFramebuffer(), and the GL_INVALID_OPERATION error in glTexSubImage3D. So we should be able to enable a bunch of tests.

This fixes several bugs, in particular the GL_INVALID_OPERATION when blitting
between 3d textures, so will allow us to enable some tests.

Pushed by jnicol@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50283c4e0a10
Update emulator to 29.2.1 and use GPU backend for wrench reftests. r=gbrown
https://hg.mozilla.org/integration/autoland/rev/45f723cd2b69
Update wrench reftest expectations for emulator 29.2.1. r=gw
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.