1584546 - On about:certificate, highlight when a certificate will expire soon/has expired

Status: NEW

(Firefox :: Security, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

We should consider adding an additional indicator for when the certificate will expire soon (or has already expired) on about:certificate.

Comment 1

[April King [:April]]

This is a great idea. How much time? I believe Let's Encrypt sends out notifications at 21 days.

Comment 2

[Carolina Jimenez Gomez]

Attachment: Bug 1584546 - highlights when a certificate will expire soon/has expired.r=keeler

Comment 3

[Carolina Jimenez Gomez]

I added this patch but I just saw that Danielle had worked on it already here https://bugzilla.mozilla.org/show_bug.cgi?id=1568974 and it looks great! I think it would be better to land that patch instead and mark this as duplicated, what do you think?

Comment 4

[Carolina Jimenez Gomez]

I just downloaded both patches and it works and doesn't break the tests from toolkit/components/certviewer/tests/, I don't understand why it is not already landed!

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I would coordinate with Danielle - it looks like that bug had some dependencies that may or may not have been resolved.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:carolina.jimenez.g, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Johann Hofmann [:johannh]]

I think Danielle's patch is more comprehensive but it only covers the error case, no? I would love to have a small highlight indicating that the cert is expiring soon.

Comment 8

[Carolina Jimenez Gomez]

That's true, I missed that part. I'll try adjusting the style the same way Danielle did in the other bug, and maybe adding the image on the top would be nice too.

Comment 9

[Carolina Jimenez Gomez]

I would like to work on top of 1568974, to avoid copying almost everything Danielle did so far - like the styling and the warning section here.

Danielle, are you still having problems rebasing your patch? I cannot work on it without being rebased. Can I help you with something?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.