Closed Bug 1584597 Opened 5 months ago Closed 5 months ago

Fix the editable menulist appearance after conversion to HTML:input

Categories

(Thunderbird :: Theme, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(3 files, 3 obsolete files)

The editable menulist looks weird under Linux and has no background colour on Windows after the conversion to HTML:input.

This makes the editable menulist looking as before. This type of menulists are used in the calendar event dialog and also in the accountWizard.

On Linux it's a bit of a hack to move the dropmarker out of the menulist like it was before. If you don't like it I can let it inside the menulist.

On the Mac accountWizard the incoming server field was too tall -> fixed. Also do the menulists have a focusring.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9096976 - Flags: review?(alessandro)

It looks good for the calendar event dialog, but there are a couple of visual quirks in the email wizard.
The input fields are missing the padding and inline start padding.
When the list is disabled and only the field is visible, it doesn't grow to fill up the empty area.

Better? It's not so easy to find the correct values with the different Linux themes.

Attachment #9096996 - Attachment is obsolete: true
Attachment #9097001 - Flags: review?(alessandro)
Attachment #9096996 - Attachment is obsolete: false
Attachment #9096976 - Attachment is obsolete: true
Attachment #9096976 - Flags: review?(alessandro)

Sorry, forgot to refresh.

Attachment #9097001 - Attachment is obsolete: true
Attachment #9097001 - Flags: review?(alessandro)
Attachment #9097003 - Flags: review?(alessandro)

Almost there, but we need a couple of small adjustments.

If you could add some padding in the menulist html|*.textbox-input declaration in the mail/base/content/menulist.css file.
Adding padding: 2px 2px 3px; will make sure the height of those field is consistent with every other field.

A small bug we're having now in the calendar even dialog is the "lock" start and end date button overlaps the dropdown markers when the fields are disabled. Screenshot to follow.

Attachment #9097003 - Flags: review?(alessandro)

(In reply to Alessandro Castellani (:aleca) from comment #5)

Almost there, but we need a couple of small adjustments.

If you could add some padding in the menulist html|*.textbox-input declaration in the mail/base/content/menulist.css file.
Adding padding: 2px 2px 3px; will make sure the height of those field is consistent with every other field.

I added it only to Linux. The normal menulists are a bit less height than the textboxes. On Windows I added a different padding to .input-field to have the same height as the normal menulists and the textboxes have the same height. On Mac the .input-field was too tall.

A small bug we're having now in the calendar even dialog is the "lock" start and end date button overlaps the dropdown markers when the fields are disabled. Screenshot to follow.

Fixed by hiding the dropmarker. The creationDialog has a rule to hide the dropmarker, made it now globally. Okay with this jumping of the chain button in even dialog?

Attachment #9097003 - Attachment is obsolete: true
Attachment #9097106 - Flags: review?(alessandro)
Comment on attachment 9097106 [details] [diff] [review]
1584597-editable-menulist-fix.patch

Review of attachment 9097106 [details] [diff] [review]:
-----------------------------------------------------------------

This is perfect.
Thank you so much for taking care of this!
Attachment #9097106 - Flags: review?(alessandro) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/294799e8fb78
Fix the editable menulist appearance after conversion to html:input. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.