Closed Bug 1584612 Opened 2 months ago Closed Last month

[wpt-sync] Sync PR 19377 - Reland "[ChromeDriver] Stop using --ignore-certificate-errors"

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: wptsync, Unassigned)

References

(Regressed 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19377 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19377
Details from upstream follow.

John Chen <johnchen@chromium.org> wrote:

Reland "[ChromeDriver] Stop using --ignore-certificate-errors"

This is a reland of 8f486945b4c91f67b76e02bfd8c39b0a9cf08089

Original change's description:

[ChromeDriver] Stop using --ignore-certificate-errors

ChromeDriver was passing --ignore-certificate-errors switch to Chrome,
regardless of whether user wants to ignore certificate errors or not.
Fixing by stop passing this flag to Chrome, and relying on using
Security.setIgnoreCertificateErrors command when user wants to ignore
certificate errors.

Bug: chromedriver:3148
Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005
Reviewed-by: Andrey Kosyakov \<caseq@chromium.org>
Commit-Queue: John Chen \<johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699890}

Bug: chromedriver:3148
Change-Id: I96ce5e6746af65e01407e7c6c92fed7428d686ec

Reviewed-on: https://chromium-review.googlesource.com/1829802
WPT-Export-Revision: d13c4d48b1c1bd2d3b9f18eecd3e7a93cab6072f

Component: web-platform-tests → geckodriver
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=4ad60c9eacfc1961e54e75061f94d4c3a2d4d36f&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=4ad60c9eacfc1961e54e75061f94d4c3a2d4d36f&label=pr_base)

Ran 1 tests and 49 subtests

### Firefox
  TIMEOUT: 1

### Chrome
  OK     : 1
  PASS   : 26

### Safari
  OK     : 1
  FAIL   : 3
  ERROR  : 23

### Firefox-only failures

/webdriver/tests/permissions/set.py: Firefox: TIMEOUT

### Other new tests that's don't pass

/webdriver/tests/permissions/set.py
   test_set_to_state[capabilities0-realmSetting2-denied]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting1-denied]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting1-prompt]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting1-granted]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting1-prompt]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters1]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting0-prompt]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters3]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters5]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting2-granted]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting0-prompt]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting0-denied]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting1-granted]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting1-denied]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting0-denied]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters7]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters2]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters4]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting0-granted]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state[capabilities0-realmSetting2-prompt]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters6]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_set_to_state_cross_realm[capabilities0-realmSetting0-granted]: Firefox: MISSING, Chrome: PASS, Safari: ERROR
   test_invalid_parameters[capabilities0-parameters0]: Firefox: MISSING, Chrome: PASS, Safari: ERROR

## Gecko CI Results

Ran 1 tests and 26 subtests
  OK     : 1
  FAIL   : 26

### New tests that don't pass
/webdriver/tests/permissions/set.py
  test_invalid_parameters[capabilities0-parameters0]: FAIL
  test_invalid_parameters[capabilities0-parameters1]: FAIL
  test_invalid_parameters[capabilities0-parameters2]: FAIL
  test_invalid_parameters[capabilities0-parameters3]: FAIL
  test_invalid_parameters[capabilities0-parameters4]: FAIL
  test_invalid_parameters[capabilities0-parameters5]: FAIL
  test_invalid_parameters[capabilities0-parameters6]: FAIL
  test_invalid_parameters[capabilities0-parameters7]: FAIL
  test_set_to_state[capabilities0-realmSetting0-denied]: FAIL
  test_set_to_state[capabilities0-realmSetting0-granted]: FAIL
  test_set_to_state[capabilities0-realmSetting0-prompt]: FAIL
  test_set_to_state[capabilities0-realmSetting1-denied]: FAIL
  test_set_to_state[capabilities0-realmSetting1-granted]: FAIL
  test_set_to_state[capabilities0-realmSetting1-prompt]: FAIL
  test_set_to_state[capabilities0-realmSetting2-denied]: FAIL
  test_set_to_state[capabilities0-realmSetting2-granted]: FAIL
  test_set_to_state[capabilities0-realmSetting2-prompt]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting0-denied]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting0-granted]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting0-prompt]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting1-denied]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting1-granted]: FAIL
  test_set_to_state_cross_realm[capabilities0-realmSetting1-prompt]: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c0ec840ec75
[wpt PR 19377] - Reland "[ChromeDriver] Stop using --ignore-certificate-errors", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/92de08c4fecf
[wpt PR 19377] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Regressions: 1526678
You need to log in before you can comment on or make changes to this bug.