Closed Bug 1584721 Opened 4 months ago Closed 4 months ago

Rework RDD/GPU shmem allocation.

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(4 files)

Splitting P4 of bug 1582353 to be on its own as it requires some ipc code modification.

Right now, the RemoteDecoderChild/Parent are explicitly sending shmem over ipc to flag them for re-use.

But this is unnecessary, we can assume when a shmem is free for re-use.

We can also extend the pooling of shmem to video codecs and not just audio.

We can deduct it from the workflow itself.

Also fix potential Shmem leak.

By default, the remote process takes ownership of a shmem when it's sent over ipc.
Using "unsafe" shmem allows any processes to read/write/deallocate such shmem.

Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae74c8a033d0
P1. Add ability to create unsafe shmem with ShmemPool. r=mjf
https://hg.mozilla.org/integration/autoland/rev/b4de320b3479
P2. Remove the need to explicitly inform child/parent that a Shmem is no longer in use. r=mjf
https://hg.mozilla.org/integration/autoland/rev/68be28f880f3
P3. Add ability to make ShmemPool dynamic in size. r=mjf
https://hg.mozilla.org/integration/autoland/rev/3f6d096c5358
P4. Recycle all ShmemBuffer including for video. r=mjf
You need to log in before you can comment on or make changes to this bug.