1584780 - layout.css.xul-box-display-values.survive-blockification.enabled breaks CFR panels

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Asa Dotzler [:asa]]

Attachment: image.png

Since enabling layout.css.xul-box-display-values.survive-blockification.enabled CFR panels are kind of a mess.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: 51b9309e6f.png

It also breaks my vertical tabs (via the "Tab Center Redux" addon), adding a black bar just right of the collapsed tabs.
On hover, the whole viewpoint shrinks, moving over content.

After disabling that flag behavior is back to normal and the vertical tab bar expands by overlaying the viewport.

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1584780 - layout.css.xul-box-display-values.survive-blockification.enabled breaks CFR panels

Comment 3

[Dão Gottwald [::dao]]

Comment on attachment 9097404 [details]
51b9309e6f.png

Please file a separate bug.

Comment 5

[Brian Grinstead [:bgrins]]

FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.

Comment 6

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #5)

FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.

Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex assert didn’t require any change after unblockification from manual testing.

We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen :ntim from comment #6)

(In reply to Brian Grinstead [:bgrins] from comment #5)

FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.

Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex didn’t require any change after unblockification from manual testing.

We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.

Thanks for the clarification - nevermind then.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e89c795c2260
layout.css.xul-box-display-values.survive-blockification.enabled breaks CFR panels r=dao

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e89c795c2260

Comment 10

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Firefox Beta 71.0 (Build ID:20191125204040) and Latest Firefox Nightly 72.0a1 (Build ID: 20191128094109) on Windows 10 x64, Mac 10.14.6 and Arch Linux 3.34.1.
All elements from the CFR panels are correctly displayed.