1584788 - Incorrect code found via PVS-Studio Static Analyzer - https://www.viva64.com/en/b/0672/#ID0EGZEK

Status: NEW

(Core :: XPCOM, defect)

Description

[Jorg K (CEST = GMT+2)]

https://searchfox.org/mozilla-central/search?q=HRESULT+result+%3D+SHGetSpecialFolderPathW(nullptr%2C+path%2C+aFolder%2C+true)%3B&case=false&regexp=false&path=
HRESULT result = SHGetSpecialFolderPathW(nullptr, path, aFolder, true);
Should be BOOL

Source: https://www.viva64.com/en/b/0672/#ID0EGZEK

There are other issues mentioned on that page, but I think it's legitimate to used delete after malloc/realloc.

Comment 1

[Jorg K (CEST = GMT+2)]

Just for your reference: This all comes from bug 1584473 comment #9.