1584789 - Incorrect code found via PVS-Studio Static Analyzer - https://www.viva64.com/en/b/0672/

Status: RESOLVED WONTFIX

(Core :: WebRTC, defect)

Description

[Jorg K (CEST = GMT+2)]

https://searchfox.org/mozilla-central/search?q=state%5Bstate_length+-+x_length+%2B+i%5D+%3D+filtered_low%5Bi%5D%3B&case=false&regexp=false&path=

Source: https://www.viva64.com/en/b/0672/ - scroll down to WebRTC

Comment 1

[Jorg K (CEST = GMT+2)]

Just for your reference: This all comes from bug 1584473 comment #9.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This looks like third-party code, but nevertheless does look wrong....

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

WebRTC_FilterAR() is only used in CNG - Comfort Noise Generation, which as of the last time I checked we don't ever actually use in mozilla's webrtc implementation. So it's an upstream bug for Chrome/webrtc (if they haven't fixed it since our last import), but in practice has no impact on us.

NI dminor to verify we're never using CNG still.

Comment 4

[Dan Minor [:dminor]]

Double checked in case it snuck in, but we don't use CNG.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Dan, can you file an upstream bug? thx

Comment 6

[Dan Minor [:dminor]]

This has been fixed upstream already. We'll get the upstream version the next time we update the webrtc.org code, but I'll mark this as WONTFIX for now since there's no point doing a cherrypick of an upstream fix to code we don't use.