Closed Bug 1584791 Opened 5 months ago Closed 5 months ago

NSPR: Incorrect code found via PVS-Studio Static Analyzer - https://www.viva64.com/en/b/0672/#ID0ELJGK

Categories

(NSPR :: NSPR, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk-bmo, Assigned: dragana)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Just for your reference: This all comes from bug 1584473 comment #9.

Looks like a regression from bug 1310197.

Flags: needinfo?(dd.mozilla)
Regressed by: 1310197

TFO is disabled and will not be enabled any time soon. I will fix it .

Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(dd.mozilla)

Does ESR 68 use the incorrect assignment code? If yes, we could do a NSPR 4.21.x bugfix release and uplift it.

I already considered to create a NSPR 4.22.x bugfix release for bug 1575821. We can fix this bug in 4.22.x, too.
FF 70 beta uses NSPR 4.22.x. If FF 70 beta requires this fix, it would be a very small uplift for beta.

Flags: needinfo?(kaie)
Blocks: 1583068
Summary: Incorrect code found via PVS-Studio Static Analyzer - https://www.viva64.com/en/b/0672/#ID0ELJGK → NSPR: Incorrect code found via PVS-Studio Static Analyzer - https://www.viva64.com/en/b/0672/#ID0ELJGK

Jörg, the question wasn't if the code is inside the codebase, but if the code is actively used or not.

Dragana's comment 3 could mean that it isn't used.

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 4.23
You need to log in before you can comment on or make changes to this bug.