1584812 - Port Bug 1562684 "[10.15][Mac] PR_GetLibraryFilePathname is returning absolute paths in MacOS Catalina" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

See Bug 1562684 Comment 31
Local builds on 10.15 seem to fail now. Because it will be released soon we should port the Mozilla bug.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1584812-macos1015-build.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Local builds on macOS 10.15 fail.
Testing completed (on m-c, etc.): 2.53 cross-compile only
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9097204 [details] [diff] [review]
1584812-macos1015-build.patch

[Triage Comment]
LGTM r/a=me

Comment 3

[Frank-Rainer Grahl (:frg)]

Geoff,

this might affect TB also. It seems only be critical if someone builds locally under 10.15 and might even be fixed by the time 10.15 is released. If you want I can do a TB patch but unable to test because these days I usually cross compile for macOS and just test there. Seems to be a 1:1 patch for Firefox too in TB.

Comment 4

[Geoff Lankow (:darktrojan)]

Thanks, I'll steal what Firefox did and apply it to Thunderbird. Not that I build for Mac or really understand the problem. ;-)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/665db3e150ae
PR_GetLibraryFilePathname is returning absolute paths in MacOS Catalina. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/2de29b2f2c3ed933481691812f51df071a78d512

Comment 7

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/bfbdb83a7c93b50023f640fc04083f5bd0287247