Closed Bug 1584835 Opened 7 years ago Closed 7 years ago

Reply with Template filter action shows empty template list

Categories

(Thunderbird :: Filters, defect)

Product:
Thunderbird
Component:
Filters
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr68 unaffected, thunderbird70 fixed, thunderbird71 unaffected)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 70.0
Tracking Flags:
Tracking Status
thunderbird_esr68 --- unaffected
thunderbird70 --- fixed
thunderbird71 --- unaffected

People

(Reporter: starless, Assigned: mkmelin)

Details

(Keywords: regression, Whiteboard: [fixed by bug 1584122])

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36

Steps to reproduce:

I saved a new message as template in one of my accounts.
I verified that the message appears in the Templates folder for the account.
I created a new message filter for the account and selected the Reply with Template action.

Actual results:

The popup list in the action area of the filter editor is empty, I cannot select any template.
This happens with Thunderbird 70.0b2 on macOS.

Expected results:

The popup list should have listed my template, to be selected.

Confirmed. Some folder popup issue, like bug 1584754.

Alice, can you please find the regression for us.

STR:
Write a message and save as template as preparation.

Tools > Message Filters, create a new filter, any condition, filter action: Reply with Template. That should let you select a/the template.

Flags: needinfo?(alice0775)

Thanks, Alice. Looks like some de-XBL fallout. Magnus, can you find a resource for this.

Flags: needinfo?(mkmelin+mozilla)

Likely from bug 1500887 then. However, WFM on trunk. Can you confirm?

Flags: needinfo?(mkmelin+mozilla)
Keywords: regression

Indeed, broken on TB 70 beta 2 and 3, working on trunk. So what do we do? We missed some backport?

Maybe I happend to fix it in bug 1584122? Not sure it's very important to fix for beta. The patch as such might not be applicable to beta.

Yes, very hard to dig around versions we (or at least I) don't build locally. I guess we have better things to do and it's not broken on ESR.

Sorry, beta users :-(

Status: NEW → RESOLVED
Closed: 7 years ago
status-thunderbird70: --- → wontfix
status-thunderbird71: --- → unaffected
status-thunderbird_esr68: --- → unaffected
tracking-thunderbird71: + → ---
Resolution: --- → WONTFIX

Alice, since you found the "fix range" in bug 1584754, can you do it here, too. Thanks in advance.

Flags: needinfo?(alice0775)

Fixed range:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a560168b6ca58f8daf34236f20d979bdf09786a1&tochange=9e2a8322e4068b2040b9483ff26849c2d0a86752
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1e0685b06c61f350da1973d419223883ba64d3e2&tochange=d23a0a0ffa93fe273c571592bdbff6aa68f6ca2b

Fixed by aab0650cbf1de00bf9f152a2ce0381f5046e7d22 Magnus Melin — Bug 1584122 - clean out some xbl related functionality: getAnonymousElementByAttribute, getAnonymousNodes. r=pmorris

Flags: needinfo?(alice0775)

I think the fix is here:
https://hg.mozilla.org/comm-central/rev/aab0650cbf1d#l8.46

I'll backport that in bug 1584122.

Will be fixed in TB 70 beta 3.

status-thunderbird70: wontfix → fixed
Resolution: WONTFIX → FIXED
Target Milestone: --- → Thunderbird 70.0
Assignee: nobody → mkmelin+mozilla
Whiteboard: [fixed by bug 1584122]
You need to log in before you can comment on or make changes to this bug.